1376995 - (photon) Update status bar color while switching between normal mode and private mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: Bug 1376995 - Update status bar color while switching between normal mode and private mode.

Review commit: https://reviewboard.mozilla.org/r/161886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161886/

Comment 2

[Jing-wei Wu [:jwu]]

Comment on attachment 8890718 [details]
Bug 1376995 - Update status bar color while switching between normal mode and private mode.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161886/diff/1-2/

Comment 3

[Julian Chu [:walkingice]]

Comment on attachment 8890718 [details]
Bug 1376995 - Update status bar color while switching between normal mode and private mode.

https://reviewboard.mozilla.org/r/161886/#review169534

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:2274
(Diff revision 2)
>                  delegate.onTabsTrayShown(this, mTabsPanel);
>              }
>          }
> +
> +        // Since tabs tray only has dark theme, always update the status bar with dark background.
> +        WindowUtil.invalidateStatusBarColor(this, /* forceDark = */ true);

I think write comment inside a line of code is not a good idea, is this necessary?

::: mobile/android/base/java/org/mozilla/gecko/util/WindowUtil.java:55
(Diff revision 2)
> +        } else {
> +            if (forceDark) { // Force to use dark background color
> +                colorResId = R.color.status_bar_bg_color_private;
> +                darkForeground = false;
> +            } else {
> +                final Tab tab = Tabs.getInstance().getSelectedTab();

If possible, to pass 'isPrivate' as parameter to here, might be better than access `Tab` here.

Comment 4

[Jing-wei Wu [:jwu]]

Comment on attachment 8890718 [details]
Bug 1376995 - Update status bar color while switching between normal mode and private mode.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161886/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cd5947b10f1
Update status bar color while switching between normal mode and private mode. r=walkingice

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3cd5947b10f1

Comment 7

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on Nightly 57 (2017-08-24).
Works fine on these devices:
Xiaomi Mi Pad 2 (Android 5.1)
Oneplus Two (Android 6.0.1)
LG Nexus 5 (Android 6.0.1)
HTC 10 (Android 7.0.1)

The status bar color is not changed on some devices:
Prestigio Grace X5 (Android 4.4.2)
HTC Nexus 9 (Android 7.1.1)
Xiaomi Mi Pad 2 (Android 5.1)
Lenovo Yoga Tablet 2 (Android 4.4.2)
I've logged a new issue for this: 1393754