137708 - [modern] close tab button shouldn't hover when disabled

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[John P Baker]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.9+)
Gecko/20020411
BuildID:    2002041111

The tabs close button shouldn't glow on hover when it
is disabled (ie only have one tab open), ideally it should
have a disabled image with the x greyed out

Reproducible: Always
Steps to Reproduce:
1. "Hide the tab bar when only one tab is open" off
2. browser window with only one tab
3. mouse over close tab button

Actual Results:  button glows

Expected Results:  button should be recognisably 'disabled'.

Comment 1

[Stephen Walker]

Attachment: patch

Comment 2

[John P Baker]

Trying the equivalent to attachment 80340 [details] [diff] [review] in userChrome.css works fine,
so patch looks good to me.

Comment 3

[John P Baker]

The disabled close button is also getting some !important styles for
.toolbarbutton[disabled="true"] which would appear to be the cause of bug 137057

Comment 4

[[e-mail]]

Comment on attachment 80340 [details] [diff] [review]
patch

Does that need !important? Many other [disabled="true"] styles seem to.

Comment 5

[[e-mail]]

*** Bug 133685 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 145406 has been marked as a duplicate of this bug. ***

Comment 7

[Boris Zbarsky [:bzbarsky]]

nominating.  this is an incredible usability problem -- a button that looks and
acts like it should do something but does nothing.

The !important is needed, because otherwise the :hover:active rule will have
higher weight than the rule you are introducing.  Which is bad -- it'll look
disabled till you click on it.

Comment 8

[Yuting Kuo]

Instead of disabling it, it should either:

1. Clear the current page and load start page/empty page.
2. Or close the window completely. 

The logic is: you have a group of tabs open, you want to close all of them one
by one, so you keep hitting the close tab button but on the last tab it doesn't
close! Which is why it should do one of the above.

Just trying to get my point in Bug 145406 across.

Comment 9

[[e-mail]]

Attachment: Patch with !important

Comment 10

[John P Baker]

Can we not correct the padding margin border problem
(bug 137057) at the same time?

.tabs-closebutton[disabled="true"] {
  margin: 0px 4px !important;
  padding: 4px 2px !important;
  border: none !important;
  list-style-image: url("chrome://global/skin/icons/close-dis.gif") !important;
}

Comment 11

[Joe Hewitt (gone)]

Attachment: patch

The right way to fix this is to cut out interference from the toolbarbutton
styles, which are wrongfully setting the border width and style for the
hover/active/disabled states, when all that changes is the color.  The rest of
the patch is pretty much the same as what neil did with a tweak to the padding.

Comment 12

[Joe Hewitt (gone)]

taking

Comment 13

[Samir Gehani]

Comment on attachment 84677 [details] [diff] [review]
patch

r=sgehani

Comment 14

[Joe Hewitt (gone)]

Comment on attachment 84677 [details] [diff] [review]
patch

sr=jag

Comment 15

[Jaime Rodriguez, Jr.]

Removing adt1.0.0, as this has not been nsbeta1+, nor given an ADT impact by the
Nav triage team. Pls work with the Nav Triage team to get this plussed, and
approved for submission to the 1.0 branch. thanks!

Comment 16

[Samir Gehani]

Nav triage team: nsbeta1+, adt3 rtm

Comment 17

[Joe Hewitt (gone)]

fixed

Comment 18

[Jaime Rodriguez, Jr.]

Mass removing adt1.0.0, and adding adt1.0.1 because, we are now on 1.0.1.

Comment 19

[scottputterman]

marking adt1.0.1- per ADT.  

Comment 20

[Patty Mac]

Talked to Jack, this one is fixed on netscape trunk build (2002-08-07-08-TRUNK)