1377093 - Build mediapipeline tests on BSDs

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Comment 1

[Jan Beich]

Attachment: Bug 1377093 - Enable mediapipeline tests on BSDs as well.

Review commit: https://reviewboard.mozilla.org/r/153262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153262/

Comment 2

[Jan Beich]

Comment on attachment 8882142 [details]
Bug 1377093 - Enable mediapipeline tests on BSDs as well.

https://reviewboard.mozilla.org/r/153262/#review158420

::: media/webrtc/signaling/gtest/moz.build:42
(Diff revision 1)
>          'jsep_track_unittest.cpp',
>          'sdp_unittests.cpp',
>      ]
>  
>      # See Bug 1372950, mediapipeline tests seem to cause crashes on Windows
> -    if CONFIG['OS_TARGET'] == 'Linux' or CONFIG['OS_TARGET'] == 'Darwin':
> +    if CONFIG['OS_TARGET'] not in ('Android', 'WINNT'):

Android uses OS_ARCH=Linux + OS_TARGET=Android. I'm just keeping statu quo here.

Comment 3

[Jan Beich]

Comment on attachment 8882142 [details]
Bug 1377093 - Enable mediapipeline tests on BSDs as well.

FreeBSD 12.0 results are positive:

$ ./mach gtest
[...]
[----------] 17 tests from MediaPipelineFilterTest
[ RUN      ] MediaPipelineFilterTest.TestConstruct
[       OK ] MediaPipelineFilterTest.TestConstruct (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestDefault
[       OK ] MediaPipelineFilterTest.TestDefault (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestSSRCFilter
[       OK ] MediaPipelineFilterTest.TestSSRCFilter (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestEmptyFilterReport0
[       OK ] MediaPipelineFilterTest.TestEmptyFilterReport0 (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestFilterReport0
[       OK ] MediaPipelineFilterTest.TestFilterReport0 (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestFilterReport0PTTruncated
[       OK ] MediaPipelineFilterTest.TestFilterReport0PTTruncated (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestFilterReport0CountTruncated
[       OK ] MediaPipelineFilterTest.TestFilterReport0CountTruncated (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestFilterReport1SSRCTruncated
[       OK ] MediaPipelineFilterTest.TestFilterReport1SSRCTruncated (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestFilterReport1BigSSRC
[       OK ] MediaPipelineFilterTest.TestFilterReport1BigSSRC (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestFilterReportMatch
[       OK ] MediaPipelineFilterTest.TestFilterReportMatch (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestFilterReportNoMatch
[       OK ] MediaPipelineFilterTest.TestFilterReportNoMatch (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestFilterUnknownRTCPType
[       OK ] MediaPipelineFilterTest.TestFilterUnknownRTCPType (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestCorrelatorFilter
[       OK ] MediaPipelineFilterTest.TestCorrelatorFilter (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestPayloadTypeFilter
[       OK ] MediaPipelineFilterTest.TestPayloadTypeFilter (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestPayloadTypeFilterSSRCUpdate
[       OK ] MediaPipelineFilterTest.TestPayloadTypeFilterSSRCUpdate (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestSSRCMovedWithCorrelator
[       OK ] MediaPipelineFilterTest.TestSSRCMovedWithCorrelator (0 ms)
[ RUN      ] MediaPipelineFilterTest.TestRemoteSDPNoSSRCs
[       OK ] MediaPipelineFilterTest.TestRemoteSDPNoSSRCs (0 ms)
[----------] 17 tests from MediaPipelineFilterTest (0 ms total)

[----------] 4 tests from MediaPipelineTest
[ RUN      ] MediaPipelineTest.TestAudioSendNoMux

Comment 4

[Dan Minor [:dminor]]

Comment on attachment 8882142 [details]
Bug 1377093 - Enable mediapipeline tests on BSDs as well.

https://reviewboard.mozilla.org/r/153262/#review158470

lgtm, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf8ffc568b8f
Enable mediapipeline tests on BSDs as well. r=dminor

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cf8ffc568b8f