Closed Bug 1377280 Opened 3 years ago Closed 3 years ago

Enable keyboard APZ on nightly

Categories

(Core :: Panning and Zooming, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 1 obsolete file)

This bug is for enabling keyboard APZ in nightly before letting it ride the trains.
Depends on: 1382521
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0696a27e6a5a8c315fa6ff227cfcb0fc17944cea
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d71331cfa14c07d1fded2b85465d02e29d30705

Two try runs with the pref enabled and bug 1382521 (which is on inbound), covering all tests for linux,windows, and macosx. It looks like it's green (except for win10 x64 debug which isn't run on inbound).
Attached patch enable-key-apz.patch (obsolete) — Splinter Review
It seems like now is a good time to land this.
Attachment #8888788 - Flags: review?(milan)
Comment on attachment 8888788 [details] [diff] [review]
enable-key-apz.patch

Review of attachment 8888788 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +702,5 @@
>  pref("apz.fling_stop_on_tap_threshold", "0.05");
>  pref("apz.fling_stopped_threshold", "0.01");
>  pref("apz.frame_delay.enabled", false);
>  pref("apz.highlight_checkerboarded_areas", false);
> +#ifdef NIGHTLY_BUILD

We should probably exclude android from this, some people use external keyboards on android devices and I don't think the XBL bindings stuff we have will work on that platform.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #3)
> Comment on attachment 8888788 [details] [diff] [review]
> enable-key-apz.patch
> 
> Review of attachment 8888788 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: modules/libpref/init/all.js
> @@ +702,5 @@
> >  pref("apz.fling_stop_on_tap_threshold", "0.05");
> >  pref("apz.fling_stopped_threshold", "0.01");
> >  pref("apz.frame_delay.enabled", false);
> >  pref("apz.highlight_checkerboarded_areas", false);
> > +#ifdef NIGHTLY_BUILD
> 
> We should probably exclude android from this, some people use external
> keyboards on android devices and I don't think the XBL bindings stuff we
> have will work on that platform.

Yeah that sounds like a good idea. I'll update the patch.
Updated to exclude Android.
Attachment #8888788 - Attachment is obsolete: true
Attachment #8888788 - Flags: review?(milan)
Attachment #8888844 - Flags: review?(bugmail)
Comment on attachment 8888844 [details] [diff] [review]
enable-key-apz.patch

Review of attachment 8888844 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8888844 - Flags: review?(bugmail) → review+
Also when this lands please send an email to dev-platform informing people that it has been enabled.
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bbe2f5be046
Enable keyboard APZ on nightly for all platforms except Android. r=kats
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #7)
> Also when this lands please send an email to dev-platform informing people
> that it has been enabled.

Will do. I'll wait a bit to make sure it'll stick.
(In reply to Ryan Hunt [:rhunt] from comment #9)
> (In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #7)
> > Also when this lands please send an email to dev-platform informing people
> > that it has been enabled.
> 
> Will do. I'll wait a bit to make sure it'll stick.

Er, I mean stick on inbound. I'll email before it lands in central.
https://hg.mozilla.org/mozilla-central/rev/0bbe2f5be046
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.