Closed Bug 1376525 Opened 4 years ago Closed 4 years ago

APZ: Enable "apz.keyboard.enabled" by default

Categories

(Core :: Panning and Zooming, enhancement, P2)

Product:
Core
Component:
Panning and Zooming
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
relnote-firefox --- 57+
firefox57 --- verified

People

(Reporter: rhunt, Assigned: rhunt)

References

(Depends on 3 open bugs, Blocks 2 open bugs)

Details

(Whiteboard: [gfx-noted][qf:p1])

Attachments

(1 file)

enable-keyboard-apz.patch
1.08 KB, patch
milan
: review+
Details | Diff | Splinter Review 
Bug 1351783 will add an initial implementation of async keyboard scrolling. This bug is for tracking the work to enable it be default.
Depends on: 1376526
Depends on: 1376538
Depends on: 1376539
Depends on: apz-keyboard
Depends on: 1376549
Moving Quantum Flow tracking information over from bug 1351783.
Blocks: QuantumFlow, QRC_FX57
Whiteboard: [gfx-noted] → [gfx-noted][qf:p1]
Depends on: 1376551
Summary: Enable "apz.keyboard.enabled" by default → APZ: Enable "apz.keyboard.enabled" by default
Depends on: 1376581
Depends on: 1376997
A few follow ups have landed in central and a few more are in inbound. My latest try run with all of these patches and the pref enabled looks green to me [1].

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=45d5da152559032b208680567f61e1ef3be89ac3&selectedJob=110821764
Depends on: 1377280
Depends on: 1383365
Depends on: 1383532
Depends on: 1383900
Adding a patch to flip the pref for whenever we want to do this.
Attachment #8893870 - Flags: review?(milan)
Cool.  I will wait for the testing to complete before r+ this for landing.
Attachment #8893870 - Flags: review?(milan) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d667710bfd65
Enable "apz.keyboard.enabled" by default. r=milan
https://hg.mozilla.org/mozilla-central/rev/d667710bfd65
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Depends on: 1396323
Release Note Request (optional, but appreciated)
[Why is this notable]:
  Asynchronous scrolling provides a smoother / less janky scrolling
  experience for users. This bug brings async scrolling to scrolling
  with the keyboard, one of the few remaining scrolling
  methods that don't have it yet.

[Affects Firefox for Android]:
  No.

[Suggested wording]:
  Scrolling with the keyboard now uses asynchronous scrolling,
  similar to other input methods like mousewheel, providing a smoother
  scrolling experience.

[Links (documentation, blog post, etc)]:
  Some links for APZ in general:

  wiki: https://wiki.mozilla.org/Platform/GFX/APZ
  blog post: https://blog.mozilla.org/firefox/smooth-scrolling-web-browser-removes-jank/
relnote-firefox: --- → ?
Flags: qe-verify+
QA Contact: petruta.rasa
Marking as verified since checking that apz.autoscroll.enabled pref is set to true was tested for pre-Beta sign off in Firefox 57.0a1 across platforms.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.