1376525 - APZ: Enable "apz.keyboard.enabled" by default

Status: VERIFIED FIXED

(Core :: Panning and Zooming, enhancement, P2)

Description

[Ryan Hunt [:rhunt]]

Bug 1351783 will add an initial implementation of async keyboard scrolling. This bug is for tracking the work to enable it be default.

Comment 1

[Botond Ballo [:botond]]

Moving Quantum Flow tracking information over from bug 1351783.

Comment 2

[Ryan Hunt [:rhunt]]

A few follow ups have landed in central and a few more are in inbound. My latest try run with all of these patches and the pref enabled looks green to me [1].

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=45d5da152559032b208680567f61e1ef3be89ac3&selectedJob=110821764

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: enable-keyboard-apz.patch

Adding a patch to flip the pref for whenever we want to do this.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Cool.  I will wait for the testing to complete before r+ this for landing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d667710bfd65
Enable "apz.keyboard.enabled" by default. r=milan

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d667710bfd65

Comment 7

[Ryan Hunt [:rhunt]]

Release Note Request (optional, but appreciated)
[Why is this notable]:
  Asynchronous scrolling provides a smoother / less janky scrolling
  experience for users. This bug brings async scrolling to scrolling
  with the keyboard, one of the few remaining scrolling
  methods that don't have it yet.

[Affects Firefox for Android]:
  No.

[Suggested wording]:
  Scrolling with the keyboard now uses asynchronous scrolling,
  similar to other input methods like mousewheel, providing a smoother
  scrolling experience.

[Links (documentation, blog post, etc)]:
  Some links for APZ in general:

  wiki: https://wiki.mozilla.org/Platform/GFX/APZ
  blog post: https://blog.mozilla.org/firefox/smooth-scrolling-web-browser-removes-jank/

Comment 8

[Petruta Horea [:phorea], Desktop Test Engineering]

Marking as verified since checking that apz.autoscroll.enabled pref is set to true was tested for pre-Beta sign off in Firefox 57.0a1 across platforms.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This was added to 57 release notes.