1377303 - Advanced Layers breaks rendering on Google Maps

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Screenshot is in bug 1375743. Pretty easy to reproduce by panning around.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

This is a bug in texture coordinate flipping required for OpenGL textures, so it only manifests with WebGL.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

I had copied texture coordinate flipping code from ImageHost, but ImageHost assumes the texture rect will always be (0, 0, 1, 1). Since AL uses a more precise region, we have to fully invert the y axis.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4146ec1d551
Fix OpenGL texture coordinate flipping in Advanced Layers. (bug 1377303, r=mattwoodrow)

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: reftests

This takes an existing webgl reftest and just plops a div over it to reproduce the texture coordinate bug.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b201ff7ac015
Add a reftest for bug 1377303. r=mattwoodrow

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d4146ec1d551
https://hg.mozilla.org/mozilla-central/rev/b201ff7ac015