Closed Bug 1377535 Opened 3 years ago Closed 3 years ago

Icons in page action popup should explicitly set a fill color

Categories

(Firefox :: Theme, defect, P1)

55 Branch
defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: Gijs, Assigned: adw)

References

(Blocks 1 open bug)

Details

(In reply to Dão Gottwald [::dao] from bug 1377165 comment #11)
> Comment on attachment 8882605 [details]
> Bug 1377165 - use correct fill colours and opacity for in-urlbar icons,
> 
> https://reviewboard.mozilla.org/r/153694/#review158896
> 
> ::: browser/themes/shared/urlbar-searchbar.inc.css:101
> (Diff revision 3)
> > +  fill: var(--toolbarbutton-icon-fill-attention);
> > +}
> > +
> > +/* Page action popup */
> > +#page-action-bookmark-button {
> > +  list-style-image: url("chrome://browser/skin/bookmark-hollow.svg");
> 
> This and related icons need to set a fill color. Can you file a new bug on
> this?

I expect the icons will currently not look good / be invisible on Linux themes where popups/panels have a dark background.
Flags: qe-verify+
Priority: -- → P2
Blocks: 1387512
Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 57.1 - Aug 15
Priority: P2 → P1
These actually get:

> photonpanelmultiview .subviewbutton {
>   -moz-context-properties: fill;
>   fill: currentColor;
> }

From here: https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUI.inc.css#1288

Same as all the other toolbarbutton images in other panel views.  I verified by checking the browser toolbox.

So I don't think there's anything to do here.  Gijs, do you agree?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Drew Willcoxon :adw from comment #1)
> These actually get:
> 
> > photonpanelmultiview .subviewbutton {
> >   -moz-context-properties: fill;
> >   fill: currentColor;
> > }
> 
> From here:
> https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/
> customizableui/panelUI.inc.css#1288
> 
> Same as all the other toolbarbutton images in other panel views.  I verified
> by checking the browser toolbox.
> 
> So I don't think there's anything to do here.  Gijs, do you agree?

SGTM!
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: needinfo?(gijskruitbosch+bugs)
Resolution: --- → WORKSFORME
Iteration: 57.1 - Aug 15 → ---
Whiteboard: [photon-structure]
You need to log in before you can comment on or make changes to this bug.