1377538 - The blocklistState property should be saved in the add-ons database

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Florian Quèze [:florian]]

Currently accessing .blocklistState triggers a load of the whole blocklist, as seen in bug 1358907, we should store this value in the add-ons database so that accessing it becomes cheap.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1377538: Store blocklistState and blocklistURL in the add-ons DB.

Review commit: https://reviewboard.mozilla.org/r/154082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154082/

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8883142 [details]
Bug 1377538: Store blocklistState and blocklistURL in the add-ons DB.

https://reviewboard.mozilla.org/r/154082/#review159946

::: toolkit/mozapps/extensions/internal/XPIProvider.jsm:4944
(Diff revision 1)
>    },
>  
> -  get blocklistState() {
> +  findBlocklistEntry() {
>      let staticItem = findMatchingStaticBlocklistItem(this);
> -    if (staticItem)
> -      return staticItem.level;
> +    if (staticItem) {
> +      let url = Services.urlFormatter.formatURLPref("extensions.blocklist.itemURL");

I'd prefer to use a const defining prefs and not sprinkle strings throughout code.

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8883142 [details]
Bug 1377538: Store blocklistState and blocklistURL in the add-ons DB.

https://reviewboard.mozilla.org/r/154082/#review159946

> I'd prefer to use a const defining prefs and not sprinkle strings throughout code.

Eh, I didn't write it, I just moved it.

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c772c634a9613256f4403e1388da9316a294206d
Bug 1377538: Store blocklistState and blocklistURL in the add-ons DB. r=rhelmer

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c772c634a961