1356825 - (aom-startup-perf) [meta] AddonManager startup is too slow

Status: NEW

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Kris Maglione [:kmag]]

AddonManager startup is the biggest single chunk of time we spend in JS at startup. A lot of this is in the system add-on bootstrap code that run, but a lot of it is overhead in the AOM itself.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Not sure if it's related, but if we could get a fast-path (or cache) of registered langpacks, we would save some time that we spend on language renegotiation that happens currently due to late registration of language resources.

Comment 2

[Kris Maglione [:kmag]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #1)
> Not sure if it's related, but if we could get a fast-path (or cache) of
> registered langpacks, we would save some time that we spend on language
> renegotiation that happens currently due to late registration of language
> resources.

I'd have to profile to see how much that would help, but if it would, we could probably make it happen after bug 1358846 lands.

Comment 3

[Florian Quèze [:florian]]

https://perfht.ml/2BHa7nQ shows ~2.4s spent for add-on manager startup on a cold startup profile on a slow machine with a nightly from 2018-02-13. Hopefully this gives ideas about where there's still room for improvement.

Comment 4

[Kris Maglione [:kmag]]

(In reply to Florian Quèze [:florian] from comment #3)
> https://perfht.ml/2BHa7nQ shows ~2.4s spent for add-on manager startup on a
> cold startup profile on a slow machine with a nightly from 2018-02-13.
> Hopefully this gives ideas about where there's still room for improvement.

The vast majority of this is still from system add-ons, with the Form Auto-fill and Pocket being by far the worst.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.

Comment 7

[Markus Stange [:mstange]]

This also affects GeckoView. During GeckoView startup we spend 260ms in AddonManager startup (on a Moto G5). This code is on the critical path during the "App link" startup scenario - it delays the initial page load.

Profiles: https://perfht.ml/2QtHocL (0.4ms interval) / https://perfht.ml/2xSYRFj (5ms interval - less information, more realistic timings)