1377617 - error-unknown-pragma warnings as errors in vtune

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom Ritter [:tjr]]

> #pragma warning (disable: 593)

in 'js/src/vtune/disable_warnings.h' causes a lot of 'error: ignoring #pragma warning  [-Werror=unknown-pragmas]' errors for the mingw build.

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1377617 Silence unknown pragma errors that occur because MinGW doesn't understand MSVC pragmas

Review commit: https://reviewboard.mozilla.org/r/153864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153864/

Comment 2

[Tom Ritter [:tjr]]

Comment on attachment 8882759 [details]
Bug 1377617 Silence unknown pragma errors that occur because MinGW doesn't understand MSVC pragmas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153864/diff/1-2/

Comment 3

[Sean Stangl [:sstangl]]

Comment on attachment 8882759 [details]
Bug 1377617 Silence unknown pragma errors that occur because MinGW doesn't understand MSVC pragmas

https://reviewboard.mozilla.org/r/153864/#review159648

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2adfa45b2f6
Silence unknown pragma errors that occur because MinGW doesn't understand MSVC pragmas r=sstangl

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b2adfa45b2f6