Closed
Bug 1377617
Opened 7 years ago
Closed 7 years ago
error-unknown-pragma warnings as errors in vtune
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
(Whiteboard: [tor])
Attachments
(1 file)
> #pragma warning (disable: 593)
in 'js/src/vtune/disable_warnings.h' causes a lot of 'error: ignoring #pragma warning [-Werror=unknown-pragmas]' errors for the mingw build.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8882759 -
Flags: review?(sstangl)
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8882759 [details]
Bug 1377617 Silence unknown pragma errors that occur because MinGW doesn't understand MSVC pragmas
https://reviewboard.mozilla.org/r/153864/#review159648
Attachment #8882759 -
Flags: review?(sstangl) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b2adfa45b2f6
Silence unknown pragma errors that occur because MinGW doesn't understand MSVC pragmas r=sstangl
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•