1377690 - Group opacity with transparent contents is broken

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Markus Stange [:mstange]]

Attachment: testcase

This testcase should have a yellow-whitish fill. With webrender + webrendest, and in servo, it has a grayish fill.

This is https://github.com/servo/webrender/issues/1449 .

Comment 1

[Darkspirit]

can reproduce.
webrender / webrender+webrendest: #dadad1
without webrender: #ffffd1

Comment 2

[Markus Stange [:mstange]]

This will be fixed by the next webrender update that includes https://github.com/servo/webrender/pull/1493 .

Comment 3

[Markus Stange [:mstange]]

If this doesn't cause more reftests to start passing, we should add one.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

(In reply to Markus Stange [:mstange] from comment #3)
> If this doesn't cause more reftests to start passing, we should add one.

It didn't, there were no new reftest passes/failures with bug 1380645 (which includes servo/webrender#1493). That's on autoland now.

Comment 5

[Darkspirit]

(In reply to Markus Stange [:mstange] from comment #0)
> Created attachment 8882833 [details]
> testcase
> 
> This testcase should have a yellow-whitish fill. With webrender +
> webrendest, and in servo, it has a grayish fill.

In Nightly 56 x64 20170721100159 @ Debian Testing (Linux 4.11.0-1-amd64, Radeon RX480)
(with a fresh profile with default settings, so without webrender/stylo)
my tab freezes/crashes and I get
bp-90011b08-9336-47ff-98ea-9c61f0170721 [@ IPCError-browser | ShutDownKill ]
with your attachment,
after I do a mousedown on the square (div), hold it, move it to the center of the window and release my mouse:
If I then do a rightclick, I don't get a context menu, or if I change to another tab and switch back, there is a loading circle until the tab crashes.
I am unsure where should I report this. It looks crazy to me that such a simple div could crash my Nightly.
Can someone reproduce this?

Comment 6

[Markus Stange [:mstange]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #4)
> (In reply to Markus Stange [:mstange] from comment #3)
> > If this doesn't cause more reftests to start passing, we should add one.
> 
> It didn't, there were no new reftest passes/failures with bug 1380645 (which
> includes servo/webrender#1493). That's on autoland now.

Ah, hmm, maybe because we're not webrendest enough to exercise those paths in our reftests. It might be worth comparing reftest results with webrendest turned on in both builds before we add a new test.

(In reply to Darkspirit from comment #5)
> I am unsure where should I report this. It looks crazy to me that such a
> simple div could crash my Nightly.
> Can someone reproduce this?

I can reproduce the content process hang on Mac with these steps to reproduce. Can you please file a new bug? Thanks!

Comment 7

[Markus Stange [:mstange]]

Fixed by bug 1380645.

We can add a test later, this bug doesn't need to stay open.

Comment 8

[Darkspirit]

(In reply to Darkspirit from comment #1)
> can reproduce.
> webrender / webrender+webrendest: #dadad1
> without webrender: #ffffd1

Webrender+Webrendest+Stylo: #ffffd1 = "yellow-whitish"
Without them: #ffffd1

Verified fixed in Nightly 56 x64 20170727100240 @ Debian Testing.