1378236 - options ui back button issue

Status: RESOLVED DUPLICATE of bug 1427991

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Peter]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170628075643

Steps to reproduce:

All four extensions (favourite-colour, forget-it, google-userinfo and stored-credentials) of the webextensions-examples, which feature an options/settings user interface show following behavior (steps to reproduce):

1. visit about:addons
2. click on settings/options ("Einstellungen" in my language) of one of the mentioned example addons -> options page gets opened
3. click back button -> the user thinks, he will get back to the about:addons page, but instead just the controls of the extension disappear
4. click back button -> now we go back to about:addons

Other extensions like Adblock Plus don't show such a behavior.


Actual results:

the controls of the extension disappear


Expected results:

get back to the about:addons page

Comment 1

[Aastha]

I would like to take this up.

Comment 2

[Caitlin Neiman [:caitmuenster]]

Awesome! Aastha, if you need any help, please feel free to needinfo Rob Helmer. Rob will be mentoring this bug. :)

Comment 4

[Aastha]

Hi!
This bug occurs for all the extensions in webextension-examples which have a options_ui key in manifest.json.
In the about:addons page for the other extension which don't have this problem they are integrated into the webpage whereas the extensions with these bugs integrate a html doc into the webpage.

I think the problem is with how option_ui key is handled in the browser. Can you tell me more about the code which handles manifest.json file of the extensions?

Thanks

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to Aastha from comment #4)
> Hi!
> This bug occurs for all the extensions in webextension-examples which have a
> options_ui key in manifest.json.
> In the about:addons page for the other extension which don't have this
> problem they are integrated into the webpage whereas the extensions with
> these bugs integrate a html doc into the webpage.
> 
> I think the problem is with how option_ui key is handled in the browser. Can
> you tell me more about the code which handles manifest.json file of the
> extensions?
> 
> Thanks

The manifest.json is parsed here:

http://searchfox.org/mozilla-central/rev/e76c0fee79a34a3612740b33508276f4b37c3ee8/toolkit/mozapps/extensions/internal/XPIInstall.jsm#319

Hope that helps, let me know if you need more info!

Comment 6

[Robert Helmer [:rhelmer]]

Oh, and thanks for working on this!

Comment 7

[Aastha]

Attachment: patch to resolve the bug

On clicking back, the controls of the action disappeared because of the onload event handling on the browser tab. I have added this condition so that it won't load a blank in the browser tag.
Kindly review it and let me know if any changes are required.

Comment 8

[Aastha]

The issue is because on clicking the back button load event fires up which sends a default blank-page to load on the browser.
This is because firefox fires up onload event. How do I make sure popstate event is called?

Comment 9

[Aastha]

(In reply to Aastha from comment #7)
> Created attachment 8913066 [details] [diff] [review]
> patch to resolve the bug

this is not correct

Comment 11

[Robert Helmer [:rhelmer]]

Comment on attachment 8913066 [details] [diff] [review]
patch to resolve the bug

Sorry for the delay! Had some access bugzilla access issues, now resolved.

Comment 12

[Ryan VanderMeulen (PTO, back July 27)]

Please attach a patch that includes commit information when requesting checkin.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#write-detailed-commit-messages

Comment 13

[Robert Helmer [:rhelmer]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #12)
> Please attach a patch that includes commit information when requesting
> checkin.
> http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/
> commits.html#write-detailed-commit-messages

Comment 14

[Andrew Swan [:aswan]]

I hadn't followed this bug closely, but I don't think this is the right fix, see the duplicate bug for details