1378277 - Overflow panel arrow is misaligned in customize mode

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Alice0775 White]

Attachment: screenshot

On Windows10

Steps To Reproduce
1. Enter customize toolbar mode

Actual Results:
Overflow panel arrow is misaligned

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1378277 - make arrow vertically align correctly in customize mode independent of font-size,

This seems to be caused by the container box being sized by font-size because
the image is being baseline-aligned, even though I don't think XUL is
supposed to do that given the <image> isn't inline-block. Anyway, setting
vertical-align: top fixes this, though it means we then need to update the
margin so we continue to overlap correctly.

Review commit: https://reviewboard.mozilla.org/r/158980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158980/

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8888083 [details]
Bug 1378277 - make arrow vertically align correctly in customize mode independent of font-size,

https://reviewboard.mozilla.org/r/158980/#review164630

LGTM, thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6577f608fb27
make arrow vertically align correctly in customize mode independent of font-size, r=mikedeboer

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6577f608fb27

Comment 6

[u554753]

Verified on Windows, Mac, and Ubuntu.