1378359 - Wrong direction of arrow indicator is displayed on RTL Arabic build

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Hani Yacoub, Desktop QA]

Attachment: arabic indicator.png

[Affected versions]: 
Nightly 56.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Ubuntu 16.10 and Mac OS X 10.12

[Steps to reproduce]:
1. 1.Download and install an RTL build: ar (Arabic).
2. Launch firefox, Go to "about:preferences" and search "التأريخ".
3. Click on the dropdown.

[Expected result]:
The direction of the indicator should be from the right to the left.

[Actual result]:
Wrong direction of arrow indicator is displayed RTL Arabic build.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Note that it unnecessary to test RTL in Arabic build. Set `intl.uidirection ` to 1 can trigger the same effect for testing RTL without waiting for local build.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1378359 - Support RTL for preferences search arrow indicator

Review commit: https://reviewboard.mozilla.org/r/154884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154884/

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8883891 [details]
Bug 1378359 - Support RTL for preferences search arrow indicator

https://reviewboard.mozilla.org/r/154884/#review159858

::: browser/themes/shared/incontentprefs/preferences.inc.css:667
(Diff revision 1)
>    height: 10px;
>    margin-inline-end: 6px;
>  }
>  
>  menulist[indicator=true] > menupopup menuitem[indicator=true]:not([image]) > .menu-iconic-left > .menu-iconic-icon {
>    list-style-image: url(chrome://global/skin/icons/search-arrow-indicator.svg);

*sigh* This icon seems very specific to about:preferences. Why does this live in toolkit? Please either fix here or file a followup or explain why it should stay as-is.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Sure! I can deal with this issue within this bug, no follow-up needed.

Can you tell me which path do you think it's the best place for search-arrow-indicator.svg? browser/themes/shared/incontent-icons or browser/themes/shared/incontentprefs?

Comment 5

[Dão Gottwald [:dao]]

browser/themes/shared/incontentprefs seems to fit best.

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8883891 [details]
Bug 1378359 - Support RTL for preferences search arrow indicator

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154884/diff/1-2/

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8883891 [details]
Bug 1378359 - Support RTL for preferences search arrow indicator

https://reviewboard.mozilla.org/r/154884/#review160210

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cece136a0b28
Support RTL for preferences search arrow indicator r=dao

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cece136a0b28

Comment 10

[Hani Yacoub, Desktop QA]

Build ID: 20170709030204
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.