1378364 - Tooltip is not displayed when searching for elements inside a popup

Status: NEW

(Firefox :: Settings UI, defect, P5)

Description

[Hani Yacoub, Desktop QA]

Attachment: Wrong tooltip.png

[Affected versions]: 
Nightly 56.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Ubuntu 16.04 and Mac OS X 10.12

[Steps to reproduce]:
1. Launch firefox, Go to "about:preferences" and search "corbel".
2. Click on "Advanced" button.

[Expected result]:
Tooltip should be displayed when searching for elements inside a popup.

[Actual result]:
Tooltip is not displayed when searching for elements inside a popup.

Comment 1

[Hani Yacoub, Desktop QA]

Attachment: tooltip not displayed.png

Sorry I uploaded the wrong screenshot above.
This is the correct one.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

To fix the issue for current search algorithm, we can add all sub-dialog string properties to "searchkeyword" attribute to make sure tooltip can be displayed correctly.

We can do a scan for all sub-dialogs and add all possible string to "searchkeyword", but it will cause a very long string since our current search algorithm is based on the keyword.

mconley, do you think this solution proposal is okay for you?

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Add Jared for feedback as well.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

I think we should be OK with not fixing this for v1 of search. The fix is simple as you have described, but these strings will be very long (all font names appended for example).

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Thanks for your feedback Jared!

In order to get double confirmation, I'd like to make sure we agree that the issue will be P3 or a post 57 enhancement (out of scope 57) for this edge case. 

The search algorithm refactoring would be needed if we would like to avoid adding a bunch of l10n string properties. I'd prefer to come out with a new solution for search algorithm since it would be better for code quality and maintainability if there are someone who want to introduce a new sub-dialog without being aware of "searchkeyword".

Jared/Mike, does it sound reasonable to you?

Comment 6

[Mike Conley (:mconley) (:⚙️)]

That sounds reasonable to me.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

That sounds reasonable to me too.

Comment 8

[Francis Lee [:frlee]]

based on the previous comments, change priority to P3

Comment 9

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: tooltip.png

Tooltip is not displayed for "Clear Data..." button from about:preferences Cookies and Site Data section, searching for "Firefox" (see tooltip.png attachment). Tested on Firefox 113.0b8, using macOS 12 and Windows 10.