Closed Bug 1378525 Opened 7 years ago Closed 6 years ago

Intermittent browser_startup_images.js | Loaded image chrome://browser/skin/tabbrowser/newtab.svg should have been shown. -

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Whiteboard: [stockwell unknown]) 

Over the last 7 days this bug has failed 44 times. ALL of the fails happen on OS X 10.10.

Here is the most recent log: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=155805883&lineNumber=2514

Here is a relevant snippet from the aforementioned log:

18:47:24     INFO - Buffered messages finished
18:47:24     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/places/folder.svg should have been shown. - 
18:47:24     INFO - Stack trace:
18:47:24     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_images.js:null:112
18:47:24     INFO - Not taking screenshot here: see the one that was previously logged
18:47:24     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/places/bookmarksToolbar@2x.png should have been shown. - 
18:47:24     INFO - Stack trace:
18:47:24     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_images.js:null:112
18:47:24     INFO - GECKO(1879) | ++DOMWINDOW == 7 (0x1238f3c00) [pid = 1880] [serial = 7] [outer = 0x117f763f0]
18:47:24     INFO - Not taking screenshot here: see the one that was previously logged
18:47:24     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/places/unfiledBookmarks.png should have been shown. -
Flags: needinfo?(past)
Whiteboard: [stockwell needswork]
Maybe caused by bug 1410072? Florian, Johann, any ideas?
Flags: needinfo?(past)
Flags: needinfo?(jhofmann)
Flags: needinfo?(florian)
Uhm, this is not the same failure as the one in the title.

Intermittent browser_startup_images.js | Loaded image chrome://browser/skin/tabbrowser/newtab.svg should have been shown.

should be treated as separate from

01:39:59     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/places/folder.svg should have been shown. - 
01:39:59     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/places/bookmarksToolbar.png should have been shown. - 
01:39:59     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/places/unfiledBookmarks.png should have been shown. -

which is the only failure I can see in the latest runs. Can we somehow ensure that we file separate bugs for separate failures for this bug?

So, something changed that makes us intermittently load places toolbar resources without showing them, or something changed around timing that makes us record these load events only now.

All these images were in the list once but I removed them as part of the code that made us record raster images properly:

https://hg.mozilla.org/mozilla-central/rev/c3c007933d81

This could have something to do with the "Bookmarks" menu entry in the top OSX menu, since these are the images that are shown there.

I'm not sure what's going on. I can try to reproduce on my machine, but if anyone has a better idea feel free to investigate.

In case we don't find a good reason for this I suggest we just put the whitelist entries back in...
Flags: needinfo?(jhofmann)
Another thought: maybe the observer mechanism that notifies us of drawing raster images has an intermittent issue?
I think it died.
Closing this one as INCOMPLETE and removing the keyword 'checkin-needed' so it doesn't get suggested in Treeherder anymore.
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: intermittent-failure
Resolution: --- → INCOMPLETE
New failures of browser_startup_images.js should be filed in separate bugs for separate failure messages. This bug as is (with different files being reported in the failures from comment 1, comment 18 and comment 21) was not actionable.
Flags: needinfo?(florian)
You need to log in before you can comment on or make changes to this bug.