1378551 - Separate `pullNewChanges` and `markChangesAsSyncing`

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P1)

Description

[Lina Butler [:lina]]

Currently, we change all NEW bookmarks to NORMAL as soon as we pull them, so that we'll write tombstones in case the upload is interrupted and the bookmark is deleted before the next sync. But we don't need to do this before downloading; we can wait until after.

Comment 1

[Lina Butler [:lina]]

Attachment: Bug 1378551 - Separate `pullNewChanges` and `markChangesAsSyncing`.

Review commit: https://reviewboard.mozilla.org/r/154666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154666/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8883746 [details]
Bug 1378551 - Separate `pullNewChanges` and `markChangesAsSyncing`.

https://reviewboard.mozilla.org/r/154666/#review159750

Comment 3

[Lina Butler [:lina]]

Comment on attachment 8883746 [details]
Bug 1378551 - Separate `pullNewChanges` and `markChangesAsSyncing`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154666/diff/1-2/

Comment 4

[Lina Butler [:lina]]

Comment on attachment 8883746 [details]
Bug 1378551 - Separate `pullNewChanges` and `markChangesAsSyncing`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154666/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39365c2e26fd
Separate `pullNewChanges` and `markChangesAsSyncing`. r=markh

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/39365c2e26fd