If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Separate `pullNewChanges` and `markChangesAsSyncing`

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Sync
P1
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: kitcambridge, Assigned: kitcambridge)

Tracking

unspecified
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Currently, we change all NEW bookmarks to NORMAL as soon as we pull them, so that we'll write tombstones in case the upload is interrupted and the bookmark is deleted before the next sync. But we don't need to do this before downloading; we can wait until after.
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8883746 [details]
Bug 1378551 - Separate `pullNewChanges` and `markChangesAsSyncing`.

https://reviewboard.mozilla.org/r/154666/#review159750
Attachment #8883746 - Flags: review?(markh) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

3 months ago
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39365c2e26fd
Separate `pullNewChanges` and `markChangesAsSyncing`. r=markh

Comment 6

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/39365c2e26fd
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Depends on: 1382363
You need to log in before you can comment on or make changes to this bug.