Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''boolean java.lang.String.equals(java.lang.Object)'' on a null object reference at org.mozilla.gecko.activitystream.ranking.HighlightsRanking$7.call(HighlightsRanking.java)

RESOLVED FIXED in Firefox 56

Status

()

P1
critical
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mccr8, Assigned: Grisha)

Tracking

({crash})

unspecified
Firefox 56
Unspecified
Android
crash
Points:
---

Firefox Tracking Flags

(firefox54 unaffected, firefox55 unaffected, firefox56 fixed)

Details

(Whiteboard: [MobileAS], crash signature)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

a year ago
This bug was filed from the Socorro interface and is 
report bp-56ec764f-2c96-4e4a-841b-b0ea50170706.
=============================================================

Tied for the top crash on the July 5th Nightly, though that's just from two installations, with 6 crashes.
(Assignee)

Updated

a year ago
Blocks: 1377247
Priority: -- → P2
Whiteboard: [MobileAS]
(Assignee)

Comment 1

a year ago
Perhaps URIs in question had an underscore character in it, and URI's getHost implementation suffers from http://bugs.java.com/view_bug.do?bug_id=6587184 ? Otherwise, these could have been relative URIs, but I don't think it's possible for us to encounter those in the ranking pipeline.

I think it'd be useful to introduce a concept of exclusion of a highlights candidate. Right now every candidate is processed; that would have been useful to have in Bug 1363521 as well.
(Assignee)

Updated

a year ago
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8886385 - Attachment is obsolete: true

Comment 7

a year ago
mozreview-review
Comment on attachment 8886384 [details]
Bug 1378967 - Pre: make our mapCursor implementation "lossy"

https://reviewboard.mozilla.org/r/157144/#review162460
Attachment #8886384 - Flags: review?(s.kaspari) → review+

Comment 8

a year ago
mozreview-review
Comment on attachment 8886386 [details]
Bug 1378967 - Ignore highlights items with opaque URIs or invalid hosts

https://reviewboard.mozilla.org/r/157148/#review162466
Attachment #8886386 - Flags: review?(s.kaspari) → review+

Comment 9

a year ago
Pushed by gkruglov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bd83e02ab47
Pre: make our mapCursor implementation "lossy" r=sebastian
https://hg.mozilla.org/integration/autoland/rev/87dc187ee1a9
Ignore highlights items with opaque URIs or invalid hosts r=sebastian

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5bd83e02ab47
https://hg.mozilla.org/mozilla-central/rev/87dc187ee1a9
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
status-firefox54: --- → unaffected
status-firefox55: --- → unaffected
You need to log in before you can comment on or make changes to this bug.