Closed Bug 1379066 Opened 7 years ago Closed 7 years ago

(photon) Awesome bar basic visual refresh

Categories

(Firefox for Android Graveyard :: General, enhancement)

Product:
Firefox for Android Graveyard
Component:
General
Version:
56 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox56 verified, firefox57 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- verified
firefox57 --- verified

People

(Reporter: walkingice, Assigned: walkingice)

References

Details

Attachments

(10 files, 1 obsolete file)

Bug 1379066 - 1. add resource files for Photon awesomebar
59 bytes, text/x-review-board-request
jwu
: review+
Details
Bug 1379066 - 2. duplicate resource action_bar_button.xml
59 bytes, text/x-review-board-request
jwu
: review+
Details
Bug 1379066 - 3. Simplify Toolbar menu in Photon flavor
59 bytes, text/x-review-board-request
jwu
: review+
Details
Bug 1379066 - 4. Readermode icon use new resource
59 bytes, text/x-review-board-request
jwu
: review+
Details
Bug 1379066 - 5. Site identity use new drawable
59 bytes, text/x-review-board-request
jwu
: review+
Details
Bug 1379066 - 6. PageAction supports Private Mode
59 bytes, text/x-review-board-request
jwu
: review+
Details
Bug 1379066 - 7. Stop button supports Private mode
59 bytes, text/x-review-board-request
jwu
: review+
Details
Bug 1379066 - 8. BrowserToolbar notify mode changing
59 bytes, text/x-review-board-request
jwu
: review+
Details
Bug 1379066 - 9. Java implementation apply different style
59 bytes, text/x-review-board-request
jwu
: review+
Details
Bug 1379066 - 10. Apply style change in xml
59 bytes, text/x-review-board-request
jwu
: review+
Details 
This is part of bug 1366670, to refresh visual of Fennec awesome bar. However Awesome bar is complex, hence it is hard to accomplish in only one bug.

This bug is the fist change for awesome bar. It includes

* to add new icon resource for photon
* make some views become themed-view to support private mode
* adjust layout to mach design spec
* tweak style in several xml files

before version 56, these changes should only effect photon flavor.
Comment on attachment 8884210 [details]
Bug 1379066 - 1. add resource files for Photon awesomebar

https://reviewboard.mozilla.org/r/155138/#review160216
Attachment #8884210 - Flags: review?(topwu.tw) → review+
Comment on attachment 8884211 [details]
Bug 1379066 - 2. duplicate resource action_bar_button.xml

https://reviewboard.mozilla.org/r/155140/#review160218
Attachment #8884211 - Flags: review?(topwu.tw) → review+
Comment on attachment 8884212 [details]
Bug 1379066 - 3. Simplify Toolbar menu in Photon flavor

https://reviewboard.mozilla.org/r/155142/#review160548

::: mobile/android/app/src/photon/res/layout-large-v11/browser_toolbar.xml:114
(Diff revision 1)
> -    <org.mozilla.gecko.widget.themed.ThemedFrameLayout
> +    <org.mozilla.gecko.widget.themed.ThemedImageButton
>          android:id="@+id/menu"
>          style="@style/UrlBar.Menu"
>          android:layout_alignWithParentIfMissing="true"
>          android:background="@drawable/browser_toolbar_action_bar_button"
> -        android:contentDescription="@string/menu">
> +        android:contentDescription="@string/menu" />

Lack of android:src="@drawable/menu"?
Attachment #8884212 - Flags: review?(topwu.tw) → review+
Comment on attachment 8884213 [details]
Bug 1379066 - 4. Readermode icon use new resource

https://reviewboard.mozilla.org/r/155144/#review160550
Attachment #8884213 - Flags: review?(topwu.tw) → review+
Comment on attachment 8884214 [details]
Bug 1379066 - 5. Site identity use new drawable

https://reviewboard.mozilla.org/r/155146/#review160552
Attachment #8884214 - Flags: review?(topwu.tw) → review+
Comment on attachment 8884215 [details]
Bug 1379066 - 6. PageAction supports Private Mode

https://reviewboard.mozilla.org/r/155148/#review160556
Attachment #8884215 - Flags: review?(topwu.tw) → review+
Comment on attachment 8884216 [details]
Bug 1379066 - 7. Stop button supports Private mode

https://reviewboard.mozilla.org/r/155150/#review160558
Attachment #8884216 - Flags: review?(topwu.tw) → review+
Comment on attachment 8884217 [details]
Bug 1379066 - 8. BrowserToolbar notify mode changing

https://reviewboard.mozilla.org/r/155152/#review160560
Attachment #8884217 - Flags: review?(topwu.tw) → review+
Comment on attachment 8884219 [details]
Bug 1379066 - 9. Java implementation apply different style

https://reviewboard.mozilla.org/r/155156/#review160562

::: mobile/android/base/java/org/mozilla/gecko/CustomEditText.java:85
(Diff revision 1)
>      @Override
>      public void setPrivateMode(boolean isPrivate) {
>          super.setPrivateMode(isPrivate);
>  
>          mHighlightColor = ContextCompat.getColor(getContext(), isPrivate
> -                ? R.color.url_bar_text_highlight_pb : R.color.fennec_ui_orange);
> +                ? R.color.url_bar_text_highlight_private: R.color.url_bar_text_highlight);

There is a checkstyle error.
https://public-artifacts.taskcluster.net/D88GyRPsQBGw7P46M0dSyQ/0/public/android/checkstyle/checkstyle.xml
Attachment #8884219 - Flags: review?(topwu.tw) → review+
Comment on attachment 8884218 [details]
Bug 1379066 - 9. Add mask to Toolbar for lightweight theme

https://reviewboard.mozilla.org/r/155154/#review160564

::: mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java:914
(Diff revision 1)
>          final Drawable drawable = getLWTDefaultStateSetDrawable();
>          if (drawable == null) {
>              return;
>          }
>  
> +        if (SkinConfig.isPhoton()) {

Should move this patch to Bug 1366661 dedicated on lightweight theme?
Attachment #8884218 - Flags: review?(topwu.tw) → review+
Comment on attachment 8884220 [details]
Bug 1379066 - 10. Apply style change in xml

https://reviewboard.mozilla.org/r/155158/#review160566
Attachment #8884220 - Flags: review?(topwu.tw) → review+
Attachment #8884218 - Attachment is obsolete: true
updated and removed Attachment #8884218 [details], since we have a Bug 1366661 for it.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5d55b64361d
1. add resource files for Photon awesomebar r=jwu
https://hg.mozilla.org/integration/autoland/rev/d60ed8c526fd
2. duplicate resource action_bar_button.xml r=jwu
https://hg.mozilla.org/integration/autoland/rev/c51ebdf28ee1
3. Simplify Toolbar menu in Photon flavor r=jwu
https://hg.mozilla.org/integration/autoland/rev/b0ba143fba67
4. Readermode icon use new resource r=jwu
https://hg.mozilla.org/integration/autoland/rev/1c2970988841
5. Site identity use new drawable r=jwu
https://hg.mozilla.org/integration/autoland/rev/449c0a4b0259
6. PageAction supports Private Mode r=jwu
https://hg.mozilla.org/integration/autoland/rev/dac98c423104
7. Stop button supports Private mode r=jwu
https://hg.mozilla.org/integration/autoland/rev/4d823e834fca
8. BrowserToolbar notify mode changing r=jwu
https://hg.mozilla.org/integration/autoland/rev/8078abd65d92
9. Java implementation apply different style r=jwu
https://hg.mozilla.org/integration/autoland/rev/d9d4bdc0a2b9
10. Apply style change in xml r=jwu
Keywords: checkin-needed
Backed out for timing out remoteautomation.py on Android x86 opt:

https://hg.mozilla.org/integration/autoland/rev/3499845a85f716cb0810d175499935570b97948c
https://hg.mozilla.org/integration/autoland/rev/cc2a27536258ea0ec939a6d340410359d24bf343
https://hg.mozilla.org/integration/autoland/rev/1c3183acf14d7e295446ea2df7a5f63f861f1c0c
https://hg.mozilla.org/integration/autoland/rev/72768321aa5b4347094c683738118e72edbd1938
https://hg.mozilla.org/integration/autoland/rev/5168c19946bdda5a0827f68c92a04c1f4b358135
https://hg.mozilla.org/integration/autoland/rev/03c01244d9c387cdf3c4a858941b335cfda32949
https://hg.mozilla.org/integration/autoland/rev/1afc420b40bdab736ad0fb17603faf43de6984e2
https://hg.mozilla.org/integration/autoland/rev/1bded84de9e07928ebab0c514ae9d7d73608b02d
https://hg.mozilla.org/integration/autoland/rev/f12ce2dad755adb3c71b83bd05dbeb149a98b57c
https://hg.mozilla.org/integration/autoland/rev/295f0b2f80472671c60266061440d45e0c5ba5b3

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d9d4bdc0a2b98e1f5ea5a1d008e97685ec00fcd4&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=113010678&repo=autoland

[task 2017-07-10T13:03:59.071188Z] 13:03:59     INFO -  TEST-START | dom/xul/templates/tests/chrome/test_tmpl_xmlquerywithsortotherfield.xul
[task 2017-07-10T13:03:59.071454Z] 13:03:59     INFO -  TEST-SKIP | dom/xul/templates/tests/chrome/test_tmpl_xmlquerywithsortotherfield.xul | took 0ms
[task 2017-07-10T13:04:01.114632Z] 13:04:01     INFO -  pushing /home/worker/workspace/build/tests/mochitest/chrome to /mnt/sdcard/tests/chrome on device...
[task 2017-07-10T13:05:37.180688Z] 13:05:37     INFO -  runtests.py | Failed to copy /home/worker/workspace/build/tests/mochitest/hyphenation to profile
[task 2017-07-10T13:05:38.157661Z] 13:05:38     INFO -  pk12util: PKCS12 IMPORT SUCCESSFUL
[task 2017-07-10T13:05:38.189487Z] 13:05:38     INFO -  MochitestServer : launching [u'/home/worker/workspace/build/hostutils/host-utils-50.0a1.en-US.linux-x86_64/xpcshell', '-g', '/home/worker/workspace/build/hostutils/host-utils-50.0a1.en-US.linux-x86_64', '-v', '170', '-f', '/home/worker/workspace/build/hostutils/host-utils-50.0a1.en-US.linux-x86_64/components/httpd.js', '-e', "const _PROFILE_PATH = '/tmp/tmp189dl7.mozrunner'; const _SERVER_PORT = '8854'; const _SERVER_ADDR = '10.0.2.2'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = false;", '-f', '/home/worker/workspace/build/tests/mochitest/server.js']
[task 2017-07-10T13:05:38.189769Z] 13:05:38     INFO -  runtests.py | Server pid: 1061
[task 2017-07-10T13:05:38.194827Z] 13:05:38     INFO -  runtests.py | Websocket server pid: 1064
[task 2017-07-10T13:05:38.203568Z] 13:05:38     INFO -  runtests.py | SSL tunnel pid: 1067
[task 2017-07-10T13:05:43.673143Z] 13:05:43     INFO -  runtests.py | Running with e10s: False
[task 2017-07-10T13:05:43.673501Z] 13:05:43     INFO -  runtests.py | Running tests: start.
[task 2017-07-10T13:05:52.416235Z] 13:05:52     INFO -  INFO | automation.py | Application pid: 1955
[task 2017-07-10T13:11:55.047816Z] 13:11:55     INFO -  TEST-INFO | started process screentopng
[task 2017-07-10T13:11:55.381673Z] 13:11:55     INFO -  TEST-INFO | screentopng: exit 0
[task 2017-07-10T13:12:01.479710Z] 13:12:01  WARNING -  TEST-UNEXPECTED-FAIL | remoteautomation.py | application timed out after 330 seconds with no output
Flags: needinfo?(walkingice0204)
rebased and fixed a issue of type casting. Let try-server to run previous failed test, now it works.
Flags: needinfo?(walkingice0204)
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c83e37f02cb
1. add resource files for Photon awesomebar r=jwu
https://hg.mozilla.org/integration/autoland/rev/e4b0ee2b48cc
2. duplicate resource action_bar_button.xml r=jwu
https://hg.mozilla.org/integration/autoland/rev/48ec90107891
3. Simplify Toolbar menu in Photon flavor r=jwu
https://hg.mozilla.org/integration/autoland/rev/6a74b011da58
4. Readermode icon use new resource r=jwu
https://hg.mozilla.org/integration/autoland/rev/22fd0f400696
5. Site identity use new drawable r=jwu
https://hg.mozilla.org/integration/autoland/rev/bcc9e34700eb
6. PageAction supports Private Mode r=jwu
https://hg.mozilla.org/integration/autoland/rev/4bc19db71a95
7. Stop button supports Private mode r=jwu
https://hg.mozilla.org/integration/autoland/rev/868142c2ccf6
8. BrowserToolbar notify mode changing r=jwu
https://hg.mozilla.org/integration/autoland/rev/e585c97066d8
9. Java implementation apply different style r=jwu
https://hg.mozilla.org/integration/autoland/rev/125924795bde
10. Apply style change in xml r=jwu
Keywords: checkin-needed
change its dependency to match EPM's expectation
Blocks: 1379650
No longer blocks: 1366670
Pixel Android 7.1 
Nightly 57.0a1 2017-08-08

Changes are visible and act accordingly.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
status-firefox57: --- → verified
QA Contact: ioana.chiorean
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: