1379089 - add core::option::expect_failed to the skip list

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Julien Cristau [:jcristau] (back August 18)]

This seems to be basically like assert in rust, so the signature should include the caller to not have all asserts lumped up (e.g. right now we have "alloc::oom::default_oom_handler | core::option::expect_failed").

Comment 1

[Julien Cristau [:jcristau] (back August 18)]

Attachment: github PR

Comment 2

[Chris Peterson [:cpeterson]]

I think we can skip all Rust functions in `std::panicking::.*` and `core::panicking::.*`.

Also, I think we should skip `core::str::slice_error_fail` from this Rust crash report: bp-2abff06f-d969-4ba5-845b-a98410170708.

Comment 3

[(Away)]

(In reply to Chris Peterson [:cpeterson] from comment #2)
> I think we can skip all Rust functions in `std::panicking::.*` and
> `core::panicking::.*`.
> 
> Also, I think we should skip `core::str::slice_error_fail` from this Rust
> crash report: bp-2abff06f-d969-4ba5-845b-a98410170708.

I'd argue that panicking::.* could go on the ignore-list (irrelevant_signature_re.txt) since they're really just common boilerplate, while slice_error_fail could go on the prefix-list (prefix_signature_re.txt) since it at least provides some information about the nature of the failure.

Comment 4

[(Away)]

> I'd argue that panicking::.* could go on the ignore-list

Oh hey, they're already there, nevermind. :-)
https://github.com/mozilla-services/socorro/blob/master/socorro/siglists/irrelevant_signature_re.txt#L12

Comment 5

[Julien Cristau [:jcristau] (back August 18)]

PR updated to add core::str::slice_error_fail

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/827e6b1941847141dedcda133421510b6e853471
Fixes bug 1379089 - add a couple of rust functions to the skip list (#3843)

* Fixes bug 1379089 - add core::option::expect_failed to the skip list

* Bug 1379089 - add core::str::slice_error_fail to the skip list

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

This deployed to stage and I reprocessed this crash. 2abff06f-d969-4ba5-845b-a98410170708#tab-details

The signature went from:

    core::str::slice_error_fail

to:

    core::str::slice_error_fail | style::gecko::media_queries::Expression::parse


We'll push that to prod either today or tomorrow.