1379099 - Replace the Style Editor spinner with a top down animation

Status: VERIFIED FIXED

(DevTools :: Style Editor, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

A spinner is displayed for 600ms as sources are added to the list... spinners just tell a user they are waiting and make the interface feel slow.

The spinner should be removed and replaced by animating the files as they appear so that they "fold down" from top to bottom, which results in a far better perceived performance.

Filter on EdgarMallory

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1379099 - Replace the Style Editor spinner with a top down animation

Review commit: https://reviewboard.mozilla.org/r/169828/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169828/

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

ntim: would you like somebody to review this?

Comment 3

[Tim Nguyen :ntim]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #2)
> ntim: would you like somebody to review this?

Should be ready for review, though I'm not sure if this is what was wanted.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Can you go to reviewboard and assign me as the reviewer and I will take a look? I think I am either miker or mikeratcliffe on reviewboard.

It looks good from what I can see but I will take a better look on Monday.

BTW: If you do this with your commit comment it is automatic:
Bug 1379099 - Replace the Style Editor spinner with a top down animation r?miker

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8898475 [details]
Bug 1379099 - Replace the Style Editor spinner with a top down animation

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169828/diff/1-2/

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 8898475 [details]
Bug 1379099 - Replace the Style Editor spinner with a top down animation

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169828/diff/2-3/

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8898475 [details]
Bug 1379099 - Replace the Style Editor spinner with a top down animation

https://reviewboard.mozilla.org/r/169828/#review180418

Looks great, r+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48bb34b7675c
Replace the Style Editor spinner with a top down animation r=miker

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/48bb34b7675c

Comment 10

[Sebastian Zartner [:sebo]]

I can confirm that it is working as described in comment 0 in Nightly 57.0a1 2017-09-02.

Having said that, now there's the disadvantage that you don't know when the style sheets finished loading and seeing a completely empty panel until the style sheets are loaded may not be much better than showing a spinner, IMO.
Though I don't have a strong opinion on this.

Sebastian