Sort UI density options by density

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Toolbars and Customization
P1
normal
VERIFIED FIXED
a month ago
16 hours ago

People

(Reporter: dao, Assigned: johannh)

Tracking

Trunk
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed, firefox57 verified)

Details

(Whiteboard: [photon-visual][p4])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a month ago
Current order of options is Normal, Compact, Touch. I think Compact, Normal, Touch would make more sense.
(Assignee)

Comment 1

a month ago
Aaron, any opinion/preference about this?
Flags: needinfo?(abenson)

Comment 2

a month ago
(In reply to Dão Gottwald [::dao] from comment #0)
> Current order of options is Normal, Compact, Touch. I think Compact, Normal,
> Touch would make more sense.

Is that from top to bottom? I like the suggestion but I wonder if we should sort by "size" by placing the larger option at the top:

Touch
Normal
Compact
Flags: needinfo?(abenson)

Updated

a month ago
Flags: qe-verify+
Priority: -- → P2
QA Contact: brindusa.tot
Whiteboard: [photon-visual][triage] → [photon-visual]
(Reporter)

Updated

a month ago
Whiteboard: [photon-visual] → [photon-visual][p4]
(Assignee)

Updated

a month ago
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
(Assignee)

Comment 3

a month ago
I think Dão's suggestion makes more sense, because the Tablet Mode checkbox works well when it's below the Touch mode menuitem. https://mozilla.invisionapp.com/share/ENBBK0F9U#/screens/229252105

Do you agree, Aaron?
Flags: needinfo?(abenson)
Comment hidden (mozreview-request)
(Reporter)

Comment 5

a month ago
mozreview-review
Comment on attachment 8886149 [details]
Bug 1379123 - Sort UI density options by density.

https://reviewboard.mozilla.org/r/156948/#review162046
Iteration: 56.3 - Jul 24 → ---
Attachment #8886149 - Flags: review?(dao+bmo) → review+
Priority: P1 → P2

Updated

a month ago
Iteration: --- → 56.3 - Jul 24
Priority: P2 → P1

Updated

a month ago
Iteration: --- → 56.3 - Jul 24
Priority: P2 → P1

Comment 6

a month ago
Ah, that's a fair point. I can get behind that! (Compact, Normal, Touch)
Flags: needinfo?(abenson)

Comment 7

a month ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30aea103f6b4
Sort UI density options by density. r=dao

Comment 8

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/30aea103f6b4
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
QA Contact: brindusa.tot → ovidiu.boca

Comment 9

16 hours ago
I verified this issue on Windows 10 and Windows 7 and Windows 10 on Surface Pro 2 with the latest Nightly 57.0a1(2017-08-16) and I can confirm the fix, the current order is Compact, Normal, Touch.
Status: RESOLVED → VERIFIED
status-firefox57: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.