1379157 - From header display when second colon in header

Status: RESOLVED INVALID

(Thunderbird :: Message Reader UI, defect)

Description

[Justin Bell]

Attachment: Renew Your Gift for 67% off!.eml

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce:

I receive an email and it misses the correct From information


Actual results:

The message says it is from "Subscriber Services <[e-mail]>" and not "Make: Subscriber Services <[e-mail]>"


Expected results:

message should show correct sender

Comment 1

[Jorg K (CEST = GMT+2)]

Right, the header is:
From: Make: Subscriber Services<[e-mail]>

And in the tread pane and headers pane TB displays:
Subscriber Services <[e-mail]>

According to RFC 2822, https://tools.ietf.org/html/rfc2822, the colon needs to be quoted, so the sender should have sent:
From: "Make: Subscriber Services" <[e-mail]>

Quoting the relevant part of RFC 2822:

display-name    =       phrase
phrase          =       1*word / obs-phrase
obs-phrase      =       word *(word / "." / CFWS)
word            =       atom / quoted-string
atom            =       [CFWS] 1*atext [CFWS]
atext           =       ALPHA / DIGIT / ; Any character except controls,
                        "!" / "#" /     ;  SP, and specials.
                        "$" / "%" /     ;  Used for atoms
                        "&" / "'" /
                        "*" / "+" /
                        "-" / "/" /
                        "=" / "?" /
                        "^" / "_" /
                        "`" / "{" /
                        "|" / "}" /
                        "~"

That makes the bug invalid, right, Alfred? However, I'm somehow intrigued that we eat "Make: " as a header.

Comment 2

[Alfred Peters [:infofrommozilla]]

Attachment: Example mail with 'group' construct

(In reply to Jorg K (GMT+2) from comment #1)
> According to RFC 2822, https://tools.ietf.org/html/rfc2822, the colon needs
> to be quoted, so the sender should have sent:

Correct.

> That makes the bug invalid, right, Alfred?

I agree with that. Because:

>  However, I'm somehow intrigued
> that we eat "Make: " as a header.

It's interpreted as a 'group construct' - a group of Mailboxes.

|    group           =   display-name ":" [group-list] ";" [CFWS]

We do not use this construct, but interpret it as a list of individual mail addresses.
When I answer to the example, TB creates two recipients, removing the group name.