1379382 - Source code links to Rust's standard library are broken

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

See for example bp-2abff06f-d969-4ba5-845b-a98410170708.

Frame 5 shows core::str::slice_error_fail with libcore/str/mod.rs:2179 linking to https://github.com/rust-lang/rust/blob/03fc9d622e0ea26a3d37f5ab030737fcca6928b9/libcore/str/mod.rs#L2179 which is 404 Not Found.

Comment 1

[Ralph Giles (:rillian)]

That should be `src/libcore/str/mod.rs`.

Comment 2

[Ralph Giles (:rillian)]

Attachment: Bug 1379382 - Correct rust srcdir url.

We were prefix matching the rust srcdir when hyperlinking
symbols, but then appending to relative source path to
the top level repo directory, resulting in broken links.

Instead, link to the srcdir on github.

Review commit: https://reviewboard.mozilla.org/r/155426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155426/

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8884545 [details]
Bug 1379382 - Correct rust srcdir url.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155426/diff/1-2/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8884545 [details]
Bug 1379382 - Correct rust srcdir url.

https://reviewboard.mozilla.org/r/155426/#review160766

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7611340c4d80
Correct rust srcdir url. r=gps

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7611340c4d80

Comment 7

[(not currently active) Ted Mielczarek]

Oh, that was dumb. Thanks for fixing that!

Comment 8

[Xidorn Quan [:xidorn] UTC+11]

Unfortunately, this is still broken. See for example the top of stack in bp-0625be8a-e875-4e76-85aa-bf53b0170726.

It has link:
> https://github.com/rust-lang/rust/src/blob/0ade339411587887bf01bcfa2e9ae4414c8900d4/liballoc/oom.rs#L26
while the correct link should be:
> https://github.com/rust-lang/rust/blob/0ade339411587887bf01bcfa2e9ae4414c8900d4/src/liballoc/oom.rs#L26

Comment 9

[Ralph Giles (:rillian)]

Oops, sorry about that. Hopefully something like this works better.

Comment 10

[Ralph Giles (:rillian)]

Confirmed fixed with a manual crash in https://crash-stats.mozilla.com/report/index/1f8b7d42-47da-4bda-a3c3-3647e0170731

Thanks to Ted for help verifying!