Source code links to Rust's standard library are broken

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: xidorn, Assigned: rillian)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
See for example bp-2abff06f-d969-4ba5-845b-a98410170708.

Frame 5 shows core::str::slice_error_fail with libcore/str/mod.rs:2179 linking to https://github.com/rust-lang/rust/blob/03fc9d622e0ea26a3d37f5ab030737fcca6928b9/libcore/str/mod.rs#L2179 which is 404 Not Found.
That should be `src/libcore/str/mod.rs`.
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Blocks: 1275424
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8884545 [details]
Bug 1379382 - Correct rust srcdir url.

https://reviewboard.mozilla.org/r/155426/#review160766
Attachment #8884545 - Flags: review?(gps) → review+

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7611340c4d80
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Oh, that was dumb. Thanks for fixing that!
(Reporter)

Comment 8

a year ago
Unfortunately, this is still broken. See for example the top of stack in bp-0625be8a-e875-4e76-85aa-bf53b0170726.

It has link:
> https://github.com/rust-lang/rust/src/blob/0ade339411587887bf01bcfa2e9ae4414c8900d4/liballoc/oom.rs#L26
while the correct link should be:
> https://github.com/rust-lang/rust/blob/0ade339411587887bf01bcfa2e9ae4414c8900d4/src/liballoc/oom.rs#L26
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

a year ago
Flags: needinfo?(giles)
Oops, sorry about that. Hopefully something like this works better.
Assignee: nobody → giles
Flags: needinfo?(giles)
(Assignee)

Updated

a year ago
Depends on: 1385503
Confirmed fixed with a manual crash in https://crash-stats.mozilla.com/report/index/1f8b7d42-47da-4bda-a3c3-3647e0170731

Thanks to Ted for help verifying!
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.