Closed
Bug 1379386
Opened 7 years ago
Closed 7 years ago
Port Bug 1364016 [Have _openURIInNewTab() provide the correct triggeringPrincipal] to TB
Categories
(Thunderbird :: General, enhancement)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 56.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(2 files)
|
1.82 KB,
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
|
1.45 KB,
patch
|
Details | Diff | Splinter Review |
We need to fix
https://dxr.mozilla.org/comm-central/rev/aa2b50ea86596b917d59ba5f6f9385b2d0a35bf2/mail/base/content/mailWindow.js#652
to make it like
https://hg.mozilla.org/mozilla-central/rev/46443484b9e6#l1.13
This function is not run in TB, but we need to implement it as part of nsBrowserAccess.
Test patch to run the function in attachment 8815364 [details] [diff] [review] from bug 1321013.
|
Assignee | |
Comment 1•7 years ago
|
||
Our implementation of openURI() doesn't call any of the interfaces that now require the triggering principal. So I've just added it and I pass it to nsIWebNavigation.loadURI() where it is also optional.
The test cases still work with or without the patch, so it's a little cosmetic.
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8884526 [details] [diff] [review]
1379386-openURI.patch
Should work :)
Attachment #8884526 -
Flags: review?(frgrahl) → review+
|
|
||
Comment 4•7 years ago
|
||
There is also bug 1361387 and a few others. We might need to check the whole c-c tree for calls which sooner or later need a triggeringPrincipal.
|
|
Assignee | |
Comment 5•7 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 56.0
You need to log in
before you can comment on or make changes to this bug.
Description
•