1379778 - Rename Compact Light and Compact Dark themes to Light and Dark

Status: RESOLVED DUPLICATE of bug 1366363

(Firefox :: Theme, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: default-vs-compact.png

The compact theme (with standard density) is actually 2px taller than the default theme on OSX. See the screenshot for a side-by-side comparison.

Comment 1

[Stephen Horlander [:shorlander]]

Now that we have separated Density from Appearance we need to rename Compact Light and Compact Dark to Light and Dark respectively.

Comment 2

[:Gijs (he/him)]

We already have bug 1366363 to rename the themes. However, I'm tempted to suggest that we should actually fix the bug here, probably by removing most/all of the custom styling here (that isn't just colours - though the colours could possibly be re-implemented using the new lwtheme stuff?), and migrating users to the compact UI density setting if they're using the compact lwthemes. Up to the visual theme if they want to split that work or just dupe this over - but we should really make sure this gets cleaned up a bit.