Closed Bug 1379785 Opened 3 years ago Closed 3 years ago
Handle spaces in package names when building symbol archives
59 bytes, text/x-review-board-request
Bug 1307301 switched the symbol package generation to python and incidentally started calling make's abspath on the archive name. Since Thunderbird is still using MOZ_PKG_PRETTYNAMES, which has package names with space, the abspath call mangles the name (it prepends PWD to each word).
Comment on attachment 8885008 [details] Bug 1379785 - Stop calling abspath on symbol_archive paths. https://reviewboard.mozilla.org/r/155830/#review161796
Attachment #8885008 - Flags: review?(gps) → review+
So we uplift this to a TB branch on mozilla-beta and build our TB 55 beta finally?
Yeah. That should fix Bug 1373284, but there might be other fallout too.
The patch applied to M-C, can you please get it checked in.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
And please add the reviewer to the commit message unless that's automatic.
landed on autoland which will get merged to m-c
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/fe939858ead4 Stop calling abspath on symbol_archive paths. r=gps
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 56.0
https://hg.mozilla.org/releases/mozilla-beta/rev/33216ed37a1fba6289b4e92000afe0be233e3b06 on THUNDERBIRD550b2_2017071401_RELBRANCH
You need to log in before you can comment on or make changes to this bug.