Handle spaces in package names when building symbol archives.

RESOLVED FIXED in Thunderbird 56.0

Status

defect
--
blocker
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tomprince, Assigned: tomprince)

Tracking

55 Branch
Thunderbird 56.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
Bug 1307301 switched the symbol package generation to python and incidentally started calling make's abspath on the archive name. Since Thunderbird is still using MOZ_PKG_PRETTYNAMES, which has package names with space, the abspath call mangles the name (it prepends PWD to each word).
Assignee

Updated

2 years ago
Blocks: 1373284
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8885008 - Flags: review?(gps)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8885008 [details]
Bug 1379785 - Stop calling abspath on symbol_archive paths.

https://reviewboard.mozilla.org/r/155830/#review161796
Attachment #8885008 - Flags: review?(gps) → review+
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
So we uplift this to a TB branch on mozilla-beta and build our TB 55 beta finally?
Assignee

Comment 5

2 years ago
Yeah. That should fix Bug 1373284, but there might be other fallout too.

Comment 6

2 years ago
The patch applied to M-C, can you please get it checked in.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(cbook)

Comment 7

2 years ago
And please add the reviewer to the commit message unless that's automatic.
landed on autoland which will get merged to m-c
Flags: needinfo?(cbook)

Comment 9

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe939858ead4
Stop calling abspath on symbol_archive paths. r=gps
Keywords: checkin-needed

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fe939858ead4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 56.0
You need to log in before you can comment on or make changes to this bug.