Closed
Bug 1379785
Opened 8 years ago
Closed 8 years ago
Handle spaces in package names when building symbol archives.
Categories
(Thunderbird :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 56.0
People
(Reporter: tomprince, Assigned: tomprince)
References
Details
Attachments
(1 file)
Bug 1307301 switched the symbol package generation to python and incidentally started calling make's abspath on the archive name. Since Thunderbird is still using MOZ_PKG_PRETTYNAMES, which has package names with space, the abspath call mangles the name (it prepends PWD to each word).
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8885008 -
Flags: review?(gps)
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885008 [details]
Bug 1379785 - Stop calling abspath on symbol_archive paths.
https://reviewboard.mozilla.org/r/155830/#review161796
Attachment #8885008 -
Flags: review?(gps) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
So we uplift this to a TB branch on mozilla-beta and build our TB 55 beta finally?
|
|
Assignee | |
Comment 5•8 years ago
|
||
Yeah. That should fix Bug 1373284, but there might be other fallout too.
|
|
||
Comment 6•8 years ago
|
||
The patch applied to M-C, can you please get it checked in.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(cbook)
|
|
||
Comment 7•8 years ago
|
||
And please add the reviewer to the commit message unless that's automatic.
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe939858ead4
Stop calling abspath on symbol_archive paths. r=gps
Keywords: checkin-needed
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 56.0
|
|
||
Comment 11•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/33216ed37a1fba6289b4e92000afe0be233e3b06
on THUNDERBIRD550b2_2017071401_RELBRANCH
You need to log in
before you can comment on or make changes to this bug.
Description
•