1379912 - Disposition flag ("replied"/"forwarded") lost if reply/forwarded message was stored as draft, draft was later edited and sent

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Christian]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170628075643

Steps to reproduce:

An email account in IMAP mode (tested with two different providers)
Click answer on an email
save your answer in the draft
close your answer
open you answer
send your answer


Actual results:

With this procedure there is no flag arrow to to indicate that the receveid message has been answered

Same problem with email transfert


Expected results:

The original (the receiveid) message shoud have a flag arrow to indicate that answer has been send

Comment 1

[Jorg K (CEST = GMT+2)]

I can confirm this issue in TB 56 Daily, most likely also broken in TB 52. Still working in TB 45.

Alice, can you find the regression for us. Thank you in advance.

Comment 2

[Alice0775 White]

Last Good:http://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win32/1483010197/
First Bad:http://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win32/1483016136/

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=fe26a515410f4bf4e500c7638e735a9f1bb79a2b&tochange=f63a0b7059c7e99e7a3435d22a0d0cb9fa35857f
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=143bb4b9249e528e658f6ccc449991794b8675f8&tochange=143bb4b9249e528e658f6ccc449991794b8675f8

Comment 3

[Jorg K (CEST = GMT+2)]

Thank to so much Alice!!

This is the change I made for bug 1322103:
https://hg.mozilla.org/comm-central/rev/f63a0b7059c7e99e7a3435d22a0d0cb9fa35857f

Comment 4

[Jorg K (CEST = GMT+2)]

Typo: Thank *you* so much, Alice!!

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1379912-mark-replied.patch (v1)

Hi Magnus. In bug 1322103 we both messed up with:
https://hg.mozilla.org/comm-central/rev/f63a0b7059c7e99e7a3435d22a0d0cb9fa35857f#l2.12

The original URI *must* be retrieved from the database, otherwise the original message is not marked as replied if we store and then edit a draft first.

So after backing this out, I found a much simpler solution to the problem of bug 1322103. We just grab a copy of the correct original URI before it gets mangled as described.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8886822 [details] [diff] [review]
1379912-mark-replied.patch (v1)

Frank-Rainer, I'm sure you could convince yourself in bug 1322172, attachment  8886881 [details] [diff] [review], that what I'm proposing for MsgComposeCommands.js works. Reverting the incorrect change from bug 1322103 in nsMsgCompose.cpp is obvious.

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8886822 [details] [diff] [review]
1379912-mark-replied.patch (v1)

Test with today's Daily. Error was clearly reproducible. 

With the fix everything worked and the original message got marked. Also tested a few edge cases like deleting the message before reply. No errors found and code looks good. r+

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1379912-mark-replied.patch (v2)

Tweaked a comment and found more spots where gOriginalMsgURI needs to be used.

Comment 9

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/a9afce55b09e805d7b095c8ae9f06a20c40c0ab5

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 8887179 [details] [diff] [review]
1379912-mark-replied.patch (v2)

This certainly needs uplift. I don't think we're doing another TB 55 beta though.

Comment 11

[Frank-Rainer Grahl (:frg)]

> Tweaked a comment and found more spots where gOriginalMsgURI needs to be used.

Sorry should have mentioned it. Thought it was intentional here.

Comment 12

[Jorg K (CEST = GMT+2)]

Comment on attachment 8887179 [details] [diff] [review]
1379912-mark-replied.patch (v2)

Not doing another TB 55 beta.

Comment 13

[Jorg K (CEST = GMT+2)]

TB 52 ESR:
https://hg.mozilla.org/releases/comm-esr52/rev/880921967a27382ff036a93f244413c19b20ec86