Closed
Bug 1380008
Opened 7 years ago
Closed 7 years ago
Splash screen added 350k in APK size
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1378688
People
(Reporter: snorp, Unassigned)
References
Details
See bug 1378688 comment #2
== Change summary for alert #7808 (as of July 11 2017 03:57 UTC) ==
Regressions:
1% installer size summary android-4-0-armv7-api15 opt 36,200,098.58 -> 36,544,662.00
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7808
Reporter | ||
Updated•7 years ago
|
Component: Theme and Visual Design → General
Comment 1•7 years ago
|
||
44K Jul 11 08:25 drawable-hdpi/firefox_logo.png
68K Jul 11 08:25 drawable-xhdpi/firefox_logo.png
128K Jul 11 08:25 drawable-xxhdpi/firefox_logo.png
202K Jul 11 08:25 drawable-xxxhdpi/firefox_logo.png
Well, that'll do it.
/drawable-xxxhdpi/firefox_logo.png PNG 464x484 464x484+0+0 8-bit sRGB 206KB
Prolly need to just back this out altogether.
Blocks: fatfennec
Reporter | ||
Comment 2•7 years ago
|
||
$ du -h app/src/main/res/*/firefox_logo.png
48K app/src/main/res/drawable-hdpi/firefox_logo.png
72K app/src/main/res/drawable-xhdpi/firefox_logo.png
132K app/src/main/res/drawable-xxhdpi/firefox_logo.png
204K app/src/main/res/drawable-xxxhdpi/firefox_logo.png
This adds up to ~450k, which presumably does not compress very well in the zip. Can we get away with just one of these and scale it? Even better, can we use a svg?
I ran pngcrush (which is probably not the state-of-the-art tool) on the largest of the above files and it reduced it to 148K. Can we at least do that?
Reporter | ||
Comment 3•7 years ago
|
||
Whoops, had written my comment before Richard but forgot to post :)
Comment 4•7 years ago
|
||
After Bug 1378688 lands, it'll be
36K firefox_logo_h.png
52K firefox_logo_x.png
88K firefox_logo_xx.png
136K firefox_logo_xxx.png
If they are still too large, we can try SVG :)
Comment 5•7 years ago
|
||
That's still around 300k zipped - testing with the Firefox logo from Wikipedia (https://de.wikipedia.org/wiki/Datei:Mozilla_Firefox_logo_2013.svg) gives me slightly less than 35k zipped, so it would still seem very much worthwhile.
Comment 6•7 years ago
|
||
Hi Jan
I tried to transfer it to VectorDrawable but it failed. I think it's becuase our logo is too complex and VectorDrawable only support a subset of SVG functionality. I've tried other source but still no luck.
What I tried to do here is to specify the size of the image using DP. And only use the largest png to scale to fit.
I think the size will smaller than the SVG file.
Please see Bug 1378688 for details.
Flags: needinfo?(jh+bugzilla)
Comment 7•7 years ago
|
||
You're right, unfortunately gradients apparently aren't supported and our logo has lots of them.
Flags: needinfo?(jh+bugzilla)
Comment 8•7 years ago
|
||
This will be fixed in Bug 1378688
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•