1380060 - Sync new local bookmarks into Mobile Bookmarks

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, enhancement, P1)

Description

[Edouard Oger [:eoger]]

Implementation details:

Let's add a new "simple" bookmarks engine that runs before the existing (read-only) bookmarks engine.
It should detect new bookmarks, pull the mobile root from the server, add these new bookmarks to the mobile root "children" collection, and upload all these records. When the upload is done, delete these records locally: the will re-appear later once we run the existing bookmarks engine.
We should not try to upload folders.

Comment 1

[Richard Newman [:rnewman]]

There's a little nuance around when this runs.

My recommendation is to do this _after_ download and _before_ merge/upload. Treat the newly downloaded buffer records as canonical, and upload with XIUS: there's no need for an additional download. On success, the buffer can be directly updated to reflect the upload, the timestamp advanced, and then the local records discarded. That sequence is interruptible and efficient.

Comment 2

[Edouard Oger [:eoger]]

Attachment: mozilla-mobile/firefox-ios#2912

Attaching the prototype I wrote before opening this bug.
This is the complete opposite of what Richard recommended, but it still seems worthwhile to put it out there.

Comment 3

[Edouard Oger [:eoger]]

Comment on attachment 8885762 [details] [review] mozilla-mobile/firefox-ios#2912

Would you mind giving me feedback on that Richard? I tried to follow the approach you outlined in comment 1.

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8885762 [details] [review] mozilla-mobile/firefox-ios#2912

This reached r+, but I've asked for it to be wrapped in a feature flag so we can land it.

Comment 5

[Richard Newman [:rnewman]]

Landed on master, preffed off:

https://github.com/mozilla-mobile/firefox-ios/commit/875829dd37e2f6b5c65490da5aa3c227d450016f

Nice work, eoger!

Stefan, could you set flags and file a follow up to pref this on when the UI work is done?