138007 - [trunk] New Profile window blank, can't create a new Profile

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[esther]

Using the linux trunk build 2002-04-17-07trunk.
This will prevent me from testing some priority bugs requiring a new profile.
1. Launch so Profile Manager comes up
2. Select Manange Profiles, click on New Profile

Result:  Blank window with buttons, buttons don't work
Expected: to be able to create a new profile

Comment 1

[esther]

*** Bug 138005 has been marked as a duplicate of this bug. ***

Comment 2

[esther]

Same problem for the mac osx build

Comment 3

[Tracy Walker [:tracy]]

profile manager is working fine with branch builds for osx 2002-04-17-05-1.0.0 
and linux 2002-04-17-09-1.0.0

this should be a smoketest blocker for trunk

Comment 4

[esther]

per bhuvan changing assigned to ben

Comment 5

[Grace Bush]

*** Bug 138004 has been marked as a duplicate of this bug. ***

Comment 6

[Grace Bush]

blocks Activation testing on trunk builds 

Comment 7

[Steve Adamski (gone)]

the first set of trunk builds this morning, are obviously terrible. Please check
this behavior again, with the result of the respin.

- the sheriff

Comment 8

[Chris McAfee]

I think ben is generally not around, I suggest a new owner here.
syd?

Comment 9

[Peter Trudelle]

Has anyone even tried to contact Ben?

Comment 10

[esther]

This is still a smoketest stopper with builds late 4-17 and window early build
4-18.  Can't test priority bugs on trunk that require a New Profile.

Comment 11

[esther]

We tested with new bits as stated in whiteboard, still a bug.

Comment 12

[scottputterman]

It's been re-tested.  Removing status whiteboard message.

Comment 13

[(not reading, please use [e-mail] instead)]

could this be jst's checkin?  doesn't the create profile wizard UI live in an
iframe?

I'll see if backing him out fixes it.

Comment 14

[Brian Nesse (gone)]

Seeing debug output:
Error reading file
jar:resource:///chrome/classic.jar!/skin/classic/global/scroll-left.gif
Error reading file
jar:resource:///chrome/classic.jar!/skin/classic/global/scroll-right.gif

When opening the create profile window. Plenty of general FE changes were
checked in, but none jump out as obvious candidates for this.

Comment 15

[(not reading, please use [e-mail] instead)]

bienvenu is going to try backing out jst.

Comment 16

[David :Bienvenu]

backing out jst's checkin fixes this one as well. Dougt is trying to get hold of
jst - if he can't, I think we're just going to have to back him out.

Comment 17

[Samir Gehani]

jst says he'll look at this.

Comment 18

[John Keiser (jkeiser)]

WFM with a Linux pull from about 35 hours ago (Wednesday 1:00AM), the pull
*definitely* has JST's changes (verified in code).  Updating again now.  Could
be an interaction with something that occurred later.

Comment 19

[bobj]

For the ones that fail, is the Classic theme installed?
Could this be related to 
  bug 13058 Can't launch browser when Classic Skin is not installed

Comment 20

[Tracy Walker [:tracy]]

classic skin is installed

Comment 21

[John Keiser (jkeiser)]

I am using modern, I just reproduced.  I was following the wrong steps before.

I get this warning when I click Next on a debug build:

Error: Missing an entry in the wizard map for null

Comment 22

[Johnny Stenback (:jst)]

Attachment: Proposed fix

Comment 23

[John Keiser (jkeiser)]

Attachment: Patch v1.1

This makes it so we don't LoadSrc twice when .src is set.  Tested against .src.

Comment 24

[Brian Ryner (not reading)]

Comment on attachment 79861 [details] [diff] [review]
Patch v1.1

r=bryner

Comment 25

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 79861 [details] [diff] [review]
Patch v1.1

sr=heikki

Comment 26

[John Keiser (jkeiser)]

Fix checked in.

Comment 27

[Johnny Stenback (:jst)]

Attachment: Aditional change that makes us not call LoadSrc() more than once when a frame exists for an iframe element

Comment 28

[John Keiser (jkeiser)]

Comment on attachment 79871 [details] [diff] [review]
Aditional change that makes us not call LoadSrc() more than once when a frame exists for an iframe element

r=jkeiser

Comment 29

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 79871 [details] [diff] [review]
Aditional change that makes us not call LoadSrc() more than once when a frame exists for an iframe element

sr=heikki

Comment 30

[esther]

trunk build 2002041814 on linux this is fixed.
trunk build 2002041814 on winme this is fixed.
leaving other platforms for tracy or k'trina to verify.

Comment 31

[Tracy Walker [:tracy]]

verified with commercial trunk builds:

win 2002-04-24-06-trunk
mac os9 2002-04-24-03-trunk