1380130 - OS X Cross Compiled builds don't work in artifact mode (try server broken)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Attempting to do an artifact build on try server is currently broken for OS X cross-compiled builds.

For a lot of people, artifact is now their default configuration, so this should be fixed asap to avoid extra turn around and cycles on try.

Example:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=81700e3a2088ac2a8a7a5f26bd442a0f985ff22a&selectedJob=113434316

https://treeherder.mozilla.org/logviewer.html#?job_id=113434316&repo=try&lineNumber=1433

  Traceback (most recent call last):
    File "/home/worker/workspace/build/src/configure.py", line 124, in <module>
      sys.exit(main(sys.argv))
    File "/home/worker/workspace/build/src/configure.py", line 29, in main
      sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 407, in run
      self._value_for(option)
    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 475, in _value_for
      return self._value_for_option(obj)
    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/util.py", line 925, in method_call
      cache[args] = self.func(instance, *args)
    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 540, in _value_for_option
      % option_string.split('=', 1)[0])
  mozbuild.configure.options.InvalidOptionError: BINDGEN_CFLAGS is not available in this configuration

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1380130 - Unset BINDGEN_CFLAGS during artifact builds on try.

Review commit: https://reviewboard.mozilla.org/r/156296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156296/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8885443 [details]
Bug 1380130 - Unset BINDGEN_CFLAGS during artifact builds on try.

https://reviewboard.mozilla.org/r/156296/#review161420

Thanks for the fix. I assume from the `mozconfig.no-compile` name that we no longer have other places we need to update this?

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8885443 [details]
Bug 1380130 - Unset BINDGEN_CFLAGS during artifact builds on try.

https://reviewboard.mozilla.org/r/156296/#review161420

e.g. `mobile/android/config/mozconfigs/android-api-15-frontend/nightly` and `mobile/android/config/mozconfigs/android-api-15-gradle-dependencies/nightly` would probably need updating if we were using bindgen on android?

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8885443 [details]
Bug 1380130 - Unset BINDGEN_CFLAGS during artifact builds on try.

https://reviewboard.mozilla.org/r/156296/#review161420

Yeah, it looks like those should be including mozconfig.no-compile... will fix in a follow-up.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e65c3896ca6a
Unset BINDGEN_CFLAGS during artifact builds on try. r=rillian

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e65c3896ca6a