Enable OSX cross-compile builds as tier1 on mozilla-central

RESOLVED FIXED

Status

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

unspecified
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(3 attachments)

+++ This bug was initially created as a clone of Bug #1373384 +++
Comment on attachment 8879303 [details]
Bug 1374422 - Enable OSX cross-compile builds as tier1 on mozilla-central.

https://reviewboard.mozilla.org/r/150578/#review155732

::: taskcluster/ci/build/macosx.yml:7
(Diff revision 1)
>      description: "MacOS X x64 Cross-compile"
>      index:
>          product: firefox
>          job-name: macosx64-debug
>      treeherder:
> -        platform: osx-10-7/debug
> +        platform: osx-10-10/debug

I guess this is to align these builds visually with the tests?  Arguably the platform here is just "osx/debug"

::: taskcluster/taskgraph/transforms/tests.py
(Diff revision 1)
> -            if build_platform.split('/')[1] == 'opt':
> -                target = 'firefox-{}.en-US.{}.dmg'.format(
> -                    get_firefox_version(),
> -                    'mac',
> -                )
> -            else:

Nice to see special-casing like this go..
Attachment #8879303 - Flags: review?(dustin) → review+
Comment on attachment 8880053 [details]
Bug 1374422 - Enable OSX Cross Compiled Nightlies.

https://reviewboard.mozilla.org/r/151376/#review156326

lgtm there is an extra space after

when:
Attachment #8880053 - Flags: review?(kmoir) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 68ff1aa745ff -d f865971d8357: rebasing 403166:68ff1aa745ff "Bug 1374422 - Enable OSX cross-compile builds as tier1 on mozilla-central. r=dustin"
merging taskcluster/ci/build/macosx.yml
merging taskcluster/ci/test/test-platforms.yml
merging taskcluster/ci/test/test-sets.yml
merging taskcluster/taskgraph/transforms/job/mozharness_test.py
merging taskcluster/taskgraph/transforms/tests.py
warning: conflicts while merging taskcluster/taskgraph/transforms/job/mozharness_test.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by Callek@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/1f4e020b1492
Enable OSX cross-compile builds as tier1 on mozilla-central. r=dustin
https://hg.mozilla.org/mozilla-central/rev/8428ab5df0b0
Enable OSX Cross Compiled Nightlies. r=kmoir
https://hg.mozilla.org/mozilla-central/rev/5456e68aafc2
Fix devedition test pointer, from bitrot bustage. r=Callek (myself) a=Kwierso
(In reply to Mozilla Autoland from comment #6)
> We're sorry, Autoland could not rebase your commits for you automatically.
> Please manually rebase your commits and try again.

Not going to bother since I was able to land to central now....
Comment on attachment 8880079 [details]
Bug 1374422 - Fix devedition test pointer, from bitrot bustage.  (myself) a=Kwierso

https://reviewboard.mozilla.org/r/151428/#review156372
Attachment #8880079 - Flags: review?(bugspam.Callek) → review+
Pushed by Callek@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/92cac74e819a
Enable OSX cross-compile builds as tier1 on mozilla-central. r=dustin
https://hg.mozilla.org/integration/autoland/rev/2c6ce6b9ae42
Enable OSX Cross Compiled Nightlies. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/686fa05da73a
Fix devedition test pointer, from bitrot bustage. r=Callek (myself) a=Kwierso
(In reply to Pulsebot from comment #13)
> Pushed by Callek@gmail.com:
> https://hg.mozilla.org/integration/autoland/rev/92cac74e819a
> Enable OSX cross-compile builds as tier1 on mozilla-central. r=dustin
> https://hg.mozilla.org/integration/autoland/rev/2c6ce6b9ae42
> Enable OSX Cross Compiled Nightlies. r=kmoir
> https://hg.mozilla.org/integration/autoland/rev/686fa05da73a
> Fix devedition test pointer, from bitrot bustage. r=Callek (myself) a=Kwierso

I changed my mind, and decided to land this set to autoland too... (to get tier 1 stuff there sooner)
Depends on: 1375271
We have successful cross compiled nightlies for macosx running on m-c.  We are going to leave the rule in place that blocks updates for macosx nightlies so we can test and update from tonight's nightly to tomorrow's nightly on the test channel, before enabling updates for all users
we enabled updates for macosx today, our work is done
Depends on: 1380130
Blocks: 1381526
You need to log in before you can comment on or make changes to this bug.