1374422 - Enable OSX cross-compile builds as tier1 on mozilla-central

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement, P1)

Description

[Justin Wood (:Callek)]

+++ This bug was initially created as a clone of Bug #1373384 +++

Comment 1

[Justin Wood (:Callek)]

Attachment: Bug 1374422 - Enable OSX cross-compile builds as tier1 on mozilla-central.

This patch enables OSX cross compiled jobs as tier 1, and additionally adds testing for OSX Nightlies via Taskcluster. Initially tested on the 'date' project branch primarily with Bug 1373384

Review commit: https://reviewboard.mozilla.org/r/150578/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150578/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8879303 [details]
Bug 1374422 - Enable OSX cross-compile builds as tier1 on mozilla-central.

https://reviewboard.mozilla.org/r/150578/#review155732

::: taskcluster/ci/build/macosx.yml:7
(Diff revision 1)
>      description: "MacOS X x64 Cross-compile"
>      index:
>          product: firefox
>          job-name: macosx64-debug
>      treeherder:
> -        platform: osx-10-7/debug
> +        platform: osx-10-10/debug

I guess this is to align these builds visually with the tests?  Arguably the platform here is just "osx/debug"

::: taskcluster/taskgraph/transforms/tests.py
(Diff revision 1)
> -            if build_platform.split('/')[1] == 'opt':
> -                target = 'firefox-{}.en-US.{}.dmg'.format(
> -                    get_firefox_version(),
> -                    'mac',
> -                )
> -            else:

Nice to see special-casing like this go..

Comment 3

[Justin Wood (:Callek)]

Attachment: Bug 1374422 - Enable OSX Cross Compiled Nightlies.

Review commit: https://reviewboard.mozilla.org/r/151376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151376/

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8879303 [details]
Bug 1374422 - Enable OSX cross-compile builds as tier1 on mozilla-central.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150578/diff/1-2/

Comment 5

[Kim Moir [:kmoir] ET]

Comment on attachment 8880053 [details]
Bug 1374422 - Enable OSX Cross Compiled Nightlies.

https://reviewboard.mozilla.org/r/151376/#review156326

lgtm there is an extra space after

when:

Comment 6

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 68ff1aa745ff -d f865971d8357: rebasing 403166:68ff1aa745ff "Bug 1374422 - Enable OSX cross-compile builds as tier1 on mozilla-central. r=dustin"
merging taskcluster/ci/build/macosx.yml
merging taskcluster/ci/test/test-platforms.yml
merging taskcluster/ci/test/test-sets.yml
merging taskcluster/taskgraph/transforms/job/mozharness_test.py
merging taskcluster/taskgraph/transforms/tests.py
warning: conflicts while merging taskcluster/taskgraph/transforms/job/mozharness_test.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 8879303 [details]
Bug 1374422 - Enable OSX cross-compile builds as tier1 on mozilla-central.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150578/diff/2-3/

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 8880053 [details]
Bug 1374422 - Enable OSX Cross Compiled Nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151376/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/1f4e020b1492
Enable OSX cross-compile builds as tier1 on mozilla-central. r=dustin
https://hg.mozilla.org/mozilla-central/rev/8428ab5df0b0
Enable OSX Cross Compiled Nightlies. r=kmoir
https://hg.mozilla.org/mozilla-central/rev/5456e68aafc2
Fix devedition test pointer, from bitrot bustage. r=Callek (myself) a=Kwierso

Comment 10

[Justin Wood (:Callek)]

(In reply to Mozilla Autoland from comment #6)
> We're sorry, Autoland could not rebase your commits for you automatically.
> Please manually rebase your commits and try again.

Not going to bother since I was able to land to central now....

Comment 11

[Justin Wood (:Callek)]

Attachment: Bug 1374422 - Fix devedition test pointer, from bitrot bustage. (myself) a=Kwierso

Review commit: https://reviewboard.mozilla.org/r/151428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151428/

Comment 12

[Justin Wood (:Callek)]

Comment on attachment 8880079 [details]
Bug 1374422 - Fix devedition test pointer, from bitrot bustage.  (myself) a=Kwierso

https://reviewboard.mozilla.org/r/151428/#review156372

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92cac74e819a
Enable OSX cross-compile builds as tier1 on mozilla-central. r=dustin
https://hg.mozilla.org/integration/autoland/rev/2c6ce6b9ae42
Enable OSX Cross Compiled Nightlies. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/686fa05da73a
Fix devedition test pointer, from bitrot bustage. r=Callek (myself) a=Kwierso

Comment 14

[Justin Wood (:Callek)]

(In reply to Pulsebot from comment #13)
> Pushed by [e-mail]:
> https://hg.mozilla.org/integration/autoland/rev/92cac74e819a
> Enable OSX cross-compile builds as tier1 on mozilla-central. r=dustin
> https://hg.mozilla.org/integration/autoland/rev/2c6ce6b9ae42
> Enable OSX Cross Compiled Nightlies. r=kmoir
> https://hg.mozilla.org/integration/autoland/rev/686fa05da73a
> Fix devedition test pointer, from bitrot bustage. r=Callek (myself) a=Kwierso

I changed my mind, and decided to land this set to autoland too... (to get tier 1 stuff there sooner)

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/92cac74e819a
https://hg.mozilla.org/mozilla-central/rev/2c6ce6b9ae42
https://hg.mozilla.org/mozilla-central/rev/686fa05da73a

Comment 16

[Kim Moir [:kmoir] ET]

We have successful cross compiled nightlies for macosx running on m-c.  We are going to leave the rule in place that blocks updates for macosx nightlies so we can test and update from tonight's nightly to tomorrow's nightly on the test channel, before enabling updates for all users

Comment 17

[Kim Moir [:kmoir] ET]

we enabled updates for macosx today, our work is done