Closed Bug 1380211 Opened 4 years ago Closed 4 years ago

Remove {} from generated id of payment request

Categories

(Core :: DOM: Web Payments, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ben.tian, Assigned: ben.tian)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Web platform test for PaymentRequest identifier usage fails for generated id with length (38) mismatches expected one (36).
https://w3c-test.org/payment-request/payment-request-id.https.html

We should remove {} from generated string {xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx} before assigning to payment request id.
Comment on attachment 8885542 [details] [diff] [review]
[final] Patch 1: Remove {} from generated id of payment request, f=alchen, r=baku

Review of attachment 8885542 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8885542 - Flags: feedback?(alchen) → feedback+
Attachment #8885542 - Flags: review?(amarchesini) → review+
Attachment #8885542 - Attachment description: Patch 1 (v1): Remove {} from generated id of payment request → [final] Patch 1: Remove {} from generated id of payment request, f=alchen, r=baku
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b688e3b2b82b
Remove {} from generated id of payment request. r=baku
Keywords: checkin-needed
No longer blocks: 1318987
https://hg.mozilla.org/mozilla-central/rev/b688e3b2b82b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.