Closed
Bug 1380211
Opened 7 years ago
Closed 7 years ago
Remove {} from generated id of payment request
Categories
(Core :: DOM: Web Payments, enhancement)
Core
DOM: Web Payments
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: ben.tian, Assigned: ben.tian)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1023 bytes,
patch
|
baku
:
review+
alchen
:
feedback+
|
Details | Diff | Splinter Review |
Web platform test for PaymentRequest identifier usage fails for generated id with length (38) mismatches expected one (36). https://w3c-test.org/payment-request/payment-request-id.https.html We should remove {} from generated string {xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx} before assigning to payment request id.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8885542 -
Flags: review?(amarchesini)
Attachment #8885542 -
Flags: feedback?(alchen)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8885542 [details] [diff] [review] [final] Patch 1: Remove {} from generated id of payment request, f=alchen, r=baku Review of attachment 8885542 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8885542 -
Flags: feedback?(alchen) → feedback+
|
||
Updated•7 years ago
|
Attachment #8885542 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8885542 -
Attachment description: Patch 1 (v1): Remove {} from generated id of payment request → [final] Patch 1: Remove {} from generated id of payment request, f=alchen, r=baku
|
|
Assignee | |
Comment 3•7 years ago
|
||
Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cd925238c16032ef7f397aafd87faab8711ebc4
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b688e3b2b82b Remove {} from generated id of payment request. r=baku
Keywords: checkin-needed
|
|
Assignee | |
Updated•7 years ago
|
Blocks: paymentrequest-wpt
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b688e3b2b82b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•