1380483 - Properly set AA, transform and use rotated buffers with OMTP capturing

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Mason Chang [Inactive] [:mchang]]

Attachment: Paint into all RotatedContent's destination DrawTargets

Previously, we were ignoring the set enables AA methods while recording with DrawTargetCapture. We were also incorrectly setting the surface format for DRawTargetCapture. Finally, we weren't drawing all portions of the content required since we could have multiple DrawTarget destinations with a RotatedBuffer. We fix this by basically cloning ClientPaintedLayer::PaintThebes. It's essentially the same function and I plan to move Record/Replay into PaintThebes once all the bugs are gone.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8885925 [details] [diff] [review]
Paint into all RotatedContent's destination DrawTargets

Review of attachment 8885925 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/ClientPaintedLayer.cpp
@@ +229,5 @@
> +                                              ClientManager()->GetPaintedLayerCallbackData());
> +
> +    ctx = nullptr;
> +
> +    target->DrawCapturedDT(captureDT, Matrix());

Should this be going through PaintThread::PaintContents? Otherwise we're throwing the async path out.

Comment 2

[Mason Chang [Inactive] [:mchang]]

Attachment: Paint into all RotatedContent's dest DrawTargets

Now with less fail. Thanks!

Comment 3

[Mason Chang [Inactive] [:mchang]]

Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=303767d5131c1551b07c9e2b0cc9ad8eec7af117

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/283cd85e6c9a
Properly set AA, transform and use rotated buffers with OMTP capturing. r=dvander

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/283cd85e6c9a