Properly set AA, transform and use rotated buffers with OMTP capturing

RESOLVED FIXED in Firefox 56

Status

()

Core
Graphics
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mchang, Assigned: mchang)

Tracking

(Blocks: 1 bug)

55 Branch
mozilla56
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
Created attachment 8885925 [details] [diff] [review]
Paint into all RotatedContent's destination DrawTargets

Previously, we were ignoring the set enables AA methods while recording with DrawTargetCapture. We were also incorrectly setting the surface format for DRawTargetCapture. Finally, we weren't drawing all portions of the content required since we could have multiple DrawTarget destinations with a RotatedBuffer. We fix this by basically cloning ClientPaintedLayer::PaintThebes. It's essentially the same function and I plan to move Record/Replay into PaintThebes once all the bugs are gone.
Attachment #8885925 - Flags: review?(dvander)
Comment on attachment 8885925 [details] [diff] [review]
Paint into all RotatedContent's destination DrawTargets

Review of attachment 8885925 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/ClientPaintedLayer.cpp
@@ +229,5 @@
> +                                              ClientManager()->GetPaintedLayerCallbackData());
> +
> +    ctx = nullptr;
> +
> +    target->DrawCapturedDT(captureDT, Matrix());

Should this be going through PaintThread::PaintContents? Otherwise we're throwing the async path out.
(Assignee)

Comment 2

a year ago
Created attachment 8885942 [details] [diff] [review]
Paint into all RotatedContent's dest DrawTargets

Now with less fail. Thanks!
Attachment #8885925 - Attachment is obsolete: true
Attachment #8885925 - Flags: review?(dvander)
Attachment #8885942 - Flags: review?(dvander)
Attachment #8885942 - Flags: review?(dvander) → review+

Comment 4

a year ago
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/283cd85e6c9a
Properly set AA, transform and use rotated buffers with OMTP capturing. r=dvander

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/283cd85e6c9a
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.