1380499 - Horizontal scrollbar appears in console, again

Status: VERIFIED FIXED

(DevTools :: Console, defect, P1)

Description

[Oriol Brufau [:Oriol]]

Open web console and fill it vertically e.g. by pressing spacebar and enter multiple times.

When the content overflows vertically and a vertical scrollbar appears, an unexpected horizontal scrollbar appears too.

This is basically like bug 1248301, but this time resizing the browser does not remove the scrollbar. A test is needed so that it won't happen a third time.

Comment 1

[Brian Grinstead [:bgrins]]

Looks like this is due to:

.webconsole-output-wrapper .message {
    width: 100vw;
}

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #1)
> Looks like this is due to:
> 
> .webconsole-output-wrapper .message {
>     width: 100vw;
> }

Can we remove this property?  I can't remember which issue it was working around but OI seems to generally work without it

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Note: On OSX you need to pass the "Show scrollbars" parameters to "always" in System Preferences to see the bug

> Can we remove this property?  I can't remember which issue it was working around but OI seems to generally work without it
I think we can, I tested various things and it seems okay without it. I guess it's a left-over from some styling I made when integrating the OI.

Comment 4

[Brian Grinstead [:bgrins]]

I'll take this, but have to wait on Bug 1326937, which moves the CSS back into webconsole.css

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: console-css.patch

Attaching via splinter because the dependencies are still on autoland. This has the CSS fix we discussed, and I've expanded the webconsole_init test to assert for the number of messages and added a regression check for the overflow. Didn't think this required a separate test file, but let me know if you think it does.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8888842 [details] [diff] [review]
console-css.patch

Review of attachment 8888842 [details] [diff] [review]:
-----------------------------------------------------------------

This looks simple and nice to me.
The test is passing with honza's patches applied, and it fails if I add back the rule you removed, so I guess we're covered.
r+ !

Comment 7

[Brian Grinstead [:bgrins]]

Try push looks OK: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c36e985d5a7445b5f608393f01a0cc1922d57923

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a072c721ee16
Prevent horizontal scrollbar from appearing in the console after vertical overflow. r=nchevobbe

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a072c721ee16

Comment 10

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

Reproduced the initial issue on 56.0a1 (2017-07-12). I can confirm the bug is verified fixed on latest Nightly 56.0a1 (2017-07-24), using Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.11.6.