Closed Bug 1380580 Opened 3 years ago Closed 3 years ago

Remove the Intel HD Graphics blocklist entry for Advanced Layers

Categories

(Core :: Graphics: Layers, enhancement)

56 Branch
enhancement
Not set

Tracking

()

VERIFIED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(1 file)

Now that we have guards in the sanity test, we have a runtime test for constant buffer offsetting, and we've improved the fallback buffer allocation paths, I think it's safe to remove the Intel HD Graphics blocklist entry.
Attached patch patchSplinter Review
Milan, this patch is very not-urgent. When you get a chance could you test the following try build on the Intel HD Graphics laptop in Toronto that was known to be broken with AL?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c62682d2889eda4c45d773809eebe2e8a51b59c

If everything's working, about:support should say "Direct3D 11 (Advanced Layers)" and there should be a line at the bottom about constant buffer offsetting being broken.
Attachment #8886077 - Flags: review?(milan)
Comment on attachment 8886077 [details] [diff] [review]
patch

I has tried http://ftp.mozilla.org/pub/firefox/try-builds/danderson@mozilla.com-5c62682d2889eda4c45d773809eebe2e8a51b59c/try-win32/, looks work on Win10 with Intel G640.

Features
Compositing	Direct3D 11 (Advanced Layers)

Workarounds
NO_CONSTANT_BUFFER_OFFSETTING	Constant buffer offset binding does not work
Attachment #8886077 - Flags: feedback+
Comment on attachment 8886077 [details] [diff] [review]
patch

Review of attachment 8886077 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine on that machine now, I get the (Advanced Layers) compositor type.
Attachment #8886077 - Flags: review?(milan) → review+
checkin-in?
Flags: needinfo?(dvander)
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3dfc5fa4c96
Remove the Intel HD Graphics blocklist entry for Advanced Layers. (bug 1380580, r=milan)
Flags: needinfo?(dvander)
Thanks for testing!
https://hg.mozilla.org/mozilla-central/rev/b3dfc5fa4c96
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Status: RESOLVED → VERIFIED
Version: 40 Branch → 56 Branch
You need to log in before you can comment on or make changes to this bug.