1380580 - Remove the Intel HD Graphics blocklist entry for Advanced Layers

Status: VERIFIED FIXED

(Core :: Graphics: Layers, enhancement)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Now that we have guards in the sanity test, we have a runtime test for constant buffer offsetting, and we've improved the fallback buffer allocation paths, I think it's safe to remove the Intel HD Graphics blocklist entry.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Milan, this patch is very not-urgent. When you get a chance could you test the following try build on the Intel HD Graphics laptop in Toronto that was known to be broken with AL?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c62682d2889eda4c45d773809eebe2e8a51b59c

If everything's working, about:support should say "Direct3D 11 (Advanced Layers)" and there should be a line at the bottom about constant buffer offsetting being broken.

Comment 2

[YF (Yang)]

Comment on attachment 8886077 [details] [diff] [review]
patch

I has tried http://ftp.mozilla.org/pub/firefox/try-builds/[e-mail]-5c62682d2889eda4c45d773809eebe2e8a51b59c/try-win32/, looks work on Win10 with Intel G640.

Features
Compositing	Direct3D 11 (Advanced Layers)

Workarounds
NO_CONSTANT_BUFFER_OFFSETTING	Constant buffer offset binding does not work

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8886077 [details] [diff] [review]
patch

Review of attachment 8886077 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine on that machine now, I get the (Advanced Layers) compositor type.

Comment 4

[YF (Yang)]

checkin-in?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3dfc5fa4c96
Remove the Intel HD Graphics blocklist entry for Advanced Layers. (bug 1380580, r=milan)

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Thanks for testing!

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b3dfc5fa4c96