Closed Bug 1380618 Opened 4 years ago Closed 4 years ago

[e10s] Uploading a file to Google plus takes a lot of time

Categories

(Core :: DOM: Content Processes, defect)

Product:
Core
Component:
DOM: Content Processes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1377589
Tracking Flags:
Tracking Status
firefox54 --- unaffected
firefox55 --- wontfix
firefox56 --- fixed

People

(Reporter: emilghitta, Assigned: baku)

References

Details

(Keywords: regression)

Attachments

(1 file)

FileReader should not do I/O on main-thread
1.74 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
[Affected versions]:
Firefox 56.0a1 (Build Id:20170712100301)
Firefox 55.0b8 (Build Id: 20170710155419)

[Unaffected versions]
Firefox 54.0.1 (Build Id: 20170628145605)

[Affected platforms]:
Windows 10 64 bit.
macOS 10.12.6.
Ubuntu 16.04 64bit.

[Steps to reproduce]:
1. Launch Firefox with a clean profile.
2. Enable e10s (if it is not already enabled).
3. Go to https://plus.google.com/ webpage.
4. Create a collection.
5. Drag a picture to the collection.


[Expected result]:
The picture is uploaded successfully in a short time.

[Actual result]:
The picture takes a lot of time to load.

[Regression range]:

This seems to be a regression:
Last good revision: c35f0ad34397990adec0612015eb1a2a566434da
First bad revision: cf6065f64f9a8aef42144e7938c9c1aec92d8677

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c35f0ad34397990adec0612015eb1a2a566434da&tochange=cf6065f64f9a8aef42144e7938c9c1aec92d8677

[Additional notes]
Please note that this issue occurs only when e10s is enabled.

For further information regarding this issue please access the following link: https://goo.gl/f7irw3
Hi Andrea!

Can you please have a look into this ? 

Thanks!
Blocks: e10s
Flags: needinfo?(amarchesini)
This patch was previously proposed as part of another bug.
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8886144 - Flags: review?(bugs)
Comment on attachment 8886144 [details] [diff] [review]
FileReader should not do I/O on main-thread

I don't understand the comment. It says something about pipe, but no pipe is created in this code. So please improve the comment, it should say that CreateInputTransport creates a pipe.
Attachment #8886144 - Flags: review?(bugs) → review+
Hi :baku, is this something we'd consider to uplift to ff55?
Flags: needinfo?(amarchesini)
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(amarchesini)
Resolution: --- → DUPLICATE
Duplicate of bug: 1377589
You need to log in before you can comment on or make changes to this bug.