1380646 - Problem with console.group and console.groupEnd with OOP extensions

Status: RESOLVED WORKSFORME

(DevTools :: Console, defect, P5)

Description

[CosminB]

Attachment: webRequest.gif

[Affected versions]:
- Firefox 56.0a1 (2017-07-12) 

[Affected platforms]:
- Windows 7 64-bit
- Ubuntu 16.04 32-bit
- Mac OS X 10.12

[Steps to reproduce]:
1.Set xpinstall.signatures.dev-root and extensions.webextensions.remote to true
2.Install https://addons-dev.allizom.org/en-US/firefox/addon/every-event/ 
3.Perform some web requests.
4.Open the browser console.
5.Observe the logs from the browser console.

[Expected results]:
- The console logs are aligned properly in the browser console.

[Actual results]:
- The console logs are not aligned properly in the browser console.

[Additional notes]:
- This issue reproduces constantly.
- Considering that Firefox 55 and Firefox 54 have the pref extensions.webextensions.remote set to false by default, I will mark these builds as disabled.

Comment 1

[Andy McKay]

The add-on being tested with here is every-event which uses group and groupEnd: https://github.com/andymckay/every-event/blob/master/background.js#L16-L19 as per https://developer.mozilla.org/en-US/docs/Web/API/Console/groupEnd

If you remove group and groupEnd from the background script, the logs come out just fine.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Hey CosminB,

Would it be possible for you to test that on Nightly ? 
We handle console.group differently there so maybe your issue will be fixed.

Comment 3

[CosminB]

Hello Nicolas Chevobbe,

This issue was tested on Firefox Nightly 56.0a1 (2017-07-12), as you can see in the description.

Thanks!

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Oh yes, sorry, I didn't see that it was in the browser console. We plan to use the new frontend for the browser console in https://bugzilla.mozilla.org/show_bug.cgi?format=default&id=1347127 which should be fixed soon-ish.

Comment 5

[Andy McKay]

Just a note that I updated the every event add-on to not use group and groupEnd until this is fixed. If you want to use that add-on to reproduce, make sure you use an older version.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Hello CosminB,

Would it be possible for you to check if this is still an issue in Nightly ?

Comment 7

[CosminB]

Attachment: Bug1380646.png

I can  reproduce the issue on Firefox 59.0.2 (20180323154952) under Win 7 64-bit.

On the latest Nightly 61.0a1 (20180416220315) under Win 7 64-bit and Mac OS X 10.13.2 I am unable to reproduce this issue.

Please see the attached screenshot.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Nice ! Let's close this bug then