Closed Bug 1362023 Opened 8 years ago Closed 7 years ago

Enable new frontend in browser console

Categories

(DevTools :: Console, enhancement, P1)

Product:
DevTools
Component:
Console
Type:
enhancement

Tracking

(firefox61 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [newconsole-mvp])

Attachments

(1 file, 1 obsolete file)

Bug 1362023 - Enable new frontend in the Browser Console unconditionally;
59 bytes, text/x-review-board-request
nchevobbe
: review+
Details
Once the new frontend is loaded in an HTML document, we should have the browser console use it. Note that the browser console, via hudservice, relies on a xul window to persist the width/height of the window. So we will probably need to add a file like browser-console.xul that has a full width/height iframe pointing to webconsole.html, and then have hudservice load the xul file.
Whiteboard: [console-html]
Depends on: 1362036
Depends on: 1307928
Flags: qe-verify?
Priority: -- → P2
Flags: qe-verify? → qe-verify+
QA Contact: iulia.cristescu
Priority: P2 → P3
Whiteboard: [console-html] → [reserve-console-html]
Priority: P3 → P4
Blocks: 1397759
Blocks: 1393914
Blocks: 1378764
Blocks: 1381834
Blocks: 1380646
Blocks: 1260877
Flags: qe-verify+
Priority: P4 → P2
QA Contact: iulia.cristescu
Whiteboard: [reserve-console-html] → [newconsole-mvp]
See Also: → 1401963
Depends on: 1432232
I'm going to start looking into this since it seems like it's also going to require some changes to better support top-level HTML windows. For example here are some of the things I've noticed so far: * persisting the width/height of the window after the user resizes it and then closes/reopens * injecting top level menu items * supporting context menu * possibly commandDispatcher support (or removing the need for it in places like https://searchfox.org/mozilla-central/source/toolkit/content/macWindowMenu.js#24) A workaround option would be to keep webconsole.xul but have it load a 100% width/height iframe pointing to webconsole.html. That seems like a pretty reasonable first step if we fix the other blockers of this bug but haven't worked out solutions to the above list.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: P2 → P1
Depends on: 1435084
Depends on: 1435090
Attachment #8947648 - Attachment is obsolete: true
Attachment #8947649 - Attachment is obsolete: true
Depends on: 1435092
Depends on: 1436076
Depends on: 1436765
Summary: Enable new console in browser console → Enable new frontend in browser console
No longer blocks: 1406060
Depends on: 1438118
Depends on: 1438542
Depends on: 1439371
Depends on: 1439616
Depends on: 1438462
Depends on: 1440385
No longer depends on: 1438462
No longer blocks: 1403188
Depends on: 1450186
Comment on attachment 8947648 [details] Bug 1362023 - Enable new frontend in the Browser Console unconditionally; https://reviewboard.mozilla.org/r/217366/#review241838 yay :)
Attachment #8947648 - Flags: review?(nchevobbe) → review+
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9866b049f5d8 Enable new frontend in the Browser Console unconditionally;r=nchevobbe
Blocks: top-level-html
https://hg.mozilla.org/mozilla-central/rev/9866b049f5d8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: