stylo: Intermittent overlapping text in Facebook comments

NEW
Unassigned

Status

()

Core
CSS Parsing and Computation
P3
normal
11 days ago
7 days ago

People

(Reporter: jdm, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 days ago
Created attachment 8886224 [details]
Screen Shot 2017-07-13 at 11.11.29 AM.png

Intermittently when I open up Facebook, I see comments that have black sans-serif text overlapping the account names. When I hover over the comment section they all restyle correctly.
(Reporter)

Comment 1

11 days ago
The inspector shows that the "Manage" text comes from the "Hide or embed this" link that appears on hover to the right of each comment.
Quick question, does it also go away if we recascade instead of restyle the whole thing? That is, if you resize the window instead of hover over the link? (don't have facebook so it's going to be hard-ish to repro for me... Though I think I've seen something similar in GH too)
Flags: needinfo?(josh)
(Reporter)

Comment 3

11 days ago
Yes, resizing the window makes it disappear as well.
Flags: needinfo?(josh)
I bet this is because the element isn't styled, and we're returning the default computed values for it, which is, default-color 16px sheriff text...

I've opened bug 1380789 to try to uplift the assertions to nightly, in order to see whether we can catch some good STR for them.
Depends on: 1380789
(In reply to Emilio Cobos Álvarez [:emilio] from comment #4)
> I bet this is because the element isn't styled, and we're returning the
> default computed values for it, which is, default-color 16px sheriff text...

It sounds like bug 1374175. In release builds, the panic does not happen, the default values are used.
Wrong bug. Bug 1371450, I meant.
(In reply to Hiroyuki Ikezoe (:hiro) from comment #6)
> Wrong bug. Bug 1371450, I meant.

Ok, let's wait for that bug to land if it's known to cause the assertions then, don't want to be crashing all over the place :)
Depends on: 1371450
Priority: -- → P3
Does this still happen?  If so, this will be fixed by bug 1381431.
You need to log in before you can comment on or make changes to this bug.