1380789 - stylo: Uplift a few assertions to nightly

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

This will hopefully help us diagnose faster the bugs we currently have no STR for.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1380789: Uplift the type assertions to nightly.

I don't think there has been going any type confusion so far, but worth catching
them sooner than later.

Review commit: https://reviewboard.mozilla.org/r/157074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157074/

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: stylo: Assert our stuff properly.

Review commit: https://reviewboard.mozilla.org/r/157076/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157076/

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8886335 [details]
stylo: Assert our stuff properly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157076/diff/1-2/

Comment 4

[Bobby Holley (:bholley)]

You should use MOZ_DIAGNOSTIC_ASSERT for the gecko-side assertions. It would be nice if we did something similar in Rust, but it would take some build config glue.

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8886335 [details]
stylo: Assert our stuff properly.

https://reviewboard.mozilla.org/r/157076/#review162358

::: commit-message-01c02:1
(Diff revision 2)
> +stylo: Assert our stuff properly. r?heycam

Sub-optimal commit message. :-)

::: servo/ports/geckolib/glue.rs:2740
(Diff revision 2)
> +    // TODO(emilio): Downgrade to debug assertions when close to release.
> +    assert!(data.has_styles(), "Resolving style on unstyled element");
> +    assert!(element.has_current_styles(&*data),
> +            "Resolving style on element without current styles");

Agreed, this should help us get better error reports, rather than whatever weirdness returning default computed values would cause.

Once we are close to release and reverting these to debug assertions, we should consider lazily computing the actual styles (rather than default computed values).

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8886334 [details]
Bug 1380789: Uplift the type assertions to nightly.

https://reviewboard.mozilla.org/r/157074/#review162360

r=me with just using MOZ_DIAGNOSTIC_ASSERT.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8886334 [details]
Bug 1380789: Uplift the type assertions to nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157074/diff/1-2/

Comment 8

[Emilio Cobos Álvarez [:emilio]]

https://hg.mozilla.org/integration/autoland/rev/c292cea0c41f

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9ec92fd4f47
Uplift the type assertions to nightly. r=heycam

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a689b0db251
followup: Fixup alignment in macro definitions. r=whitespace-only

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e9ec92fd4f47
https://hg.mozilla.org/mozilla-central/rev/6a689b0db251