1380733 - Light Themes/Appearances/Personas look faded and bleached after landing patch from bug #1377789 & bug #1367439

Status: VERIFIED INVALID

(Firefox :: Theme, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug.png

STR:
1. Use some Light Theme/Appearance/Persona (like for example - ( https://addons.mozilla.org/en-US/firefox/addon/virtualfox/ )
and see that color is faded and bleached compared to older Firefox versions and doesn't represent original color from Light Theme/Appearance/Persona


"Speedy" Regression window (mozilla-central)
Good:
https://ftp.mozilla.org/pub/firefox/nightly/2017/07/2017-07-12-03-02-04-mozilla-central/

Bad:
https://ftp.mozilla.org/pub/firefox/nightly/2017/07/2017-07-13-03-02-05-mozilla-central/

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=09a4282d1172ac255038e7ccacfd772140b219e2&tochange=30ea2905130e85f9e1d8d56fa3097901eec6514b

Can be caused by:
bug #1377789 [Firefox:Theme]-Transition between tab bar and address bar is broken with Light Theme/Appearance/Persona after landing patch from bug #1367439
bug #1379268 [Firefox:Theme]-Switching between Firefox windows caused tab background color to lag behind titlebar

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug.png

Comment 2

[Dão Gottwald [:dao]]

This is just expected pre-bug 1367439 behavior. It's the same as what we've shipped for quite some time, too.

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Hmm, true,
but there is still issue in transition, but only after landing bug #1377789 make it just more visible, especially with Menu Bar enabled, what's more color of Light Themes/Appearances/Personas is clearly broken and doesn't represent original color.

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: issue.png

Comment 5

[Dão Gottwald [:dao]]

I don't see any issue in your screenshot.

Comment 6

[Dão Gottwald [:dao]]

Oops, I didn't mean to resolve this. Gonna mark this as invalid though, while I'm at it.

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

There are 2 issues.
1. See transition (or more like no transition, as there are non now) between Menu Bar with background tabs - foreground tab with its toolbar and Bookmark Toolbar
2. The original color of Light Themes/Appearances/Personas is not represented in Firefox, it's faded and bleached

It you don't see it, compare Firefox 55 and Firefox 56 with same settings.

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: color issue - original Persona vs Persona in Firefox.png

Comment 9

[Dão Gottwald [:dao]]

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #7)
> There are 2 issues.
> 1. See transition (or more like no transition, as there are non now) between
> Menu Bar with background tabs - foreground tab with its toolbar and Bookmark
> Toolbar

Sorry, I have no idea what you're talking about here.

> 2. The original color of Light Themes/Appearances/Personas is not
> represented in Firefox, it's faded and bleached

That's the expected outcome of bug 1377789.

Windows 7 is now using the same effect as we were already using on Windows 8 and later. Maybe this is the change you're talking about, but that's intentional too.