Closed Bug 1380781 Opened 7 years ago Closed 7 years ago

Mac release promotion l10n repacks fail to download find mkfshfs

Categories

(Release Engineering :: Release Automation: Other, defect, P1)

defect

Tracking

(firefox56 fixed)

RESOLVED FIXED
Tracking Status
firefox56 --- fixed

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(1 file)

12:02:08     INFO -   0:12.88 checking for mkfshfs... not found
12:02:08     INFO -   0:12.88 DEBUG: mkfshfs: Trying /builds/slave/rel-jamun_fx_m64_l10n_rpk-0000/build/jamun/hfsplus-tools/newfs_hfs
12:02:08     INFO -   0:12.88 ERROR: Cannot find mkfshfs
12:02:08     INFO -   0:12.92 *** Fix above errors and then restart with               "/usr/bin/make -f client.mk build"
12:02:08     INFO -   0:12.92 make: *** [configure] Error 1
12:02:08    ERROR - Return code: 2
Depends on: 1375271
Looks like it helped (with reverted https://hg.mozilla.org/mozilla-central/rev/89ec4b65a5f6). Callek, do you think this may affect nightly l10n repacks (if we proceed with backout)?
Flags: needinfo?(bugspam.Callek)
(In reply to Rail Aliiev [:rail] ⌚️ET from comment #2)
> Looks like it helped (with reverted
> https://hg.mozilla.org/mozilla-central/rev/89ec4b65a5f6). Callek, do you
> think this may affect nightly l10n repacks (if we proceed with backout)?

If we backout before beta it will break Nightly repacks.  There may be a way to make a patch that works on nightly and beta, but I'd want to defer that knowledge to a build peer, (like :mshal or :glandium)
Flags: needinfo?(bugspam.Callek)
we can probably add some "if `uname` == 'Linux'` there...
Mike, what you say wrt comment 2?
Flags: needinfo?(mh+mozilla)
Comment 6 looks like a good workaround.
Flags: needinfo?(mh+mozilla)
It worked fine
Comment on attachment 8887277 [details]
Bug 1380781 - Mac release promotion l10n repacks fail to download find mkfshfs

https://reviewboard.mozilla.org/r/158074/#review163326

::: browser/config/mozconfigs/macosx64/l10n-mozconfig:4
(Diff revision 1)
>  . "$topsrcdir/browser/config/mozconfigs/common"
>  . "$topsrcdir/build/mozconfig.no-compile"
>  
> +if test `uname` = "Linux"; then

might be better to make that uname -s.
Attachment #8887277 - Flags: review?(mh+mozilla) → review+
Pushed by raliiev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48c6a63f1ac8
Mac release promotion l10n repacks fail to download find mkfshfs r=glandium
https://hg.mozilla.org/mozilla-central/rev/48c6a63f1ac8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: