1380781 - Mac release promotion l10n repacks fail to download find mkfshfs

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect, P1)

Description

[Rail Aliiev [:rail]]

12:02:08     INFO -   0:12.88 checking for mkfshfs... not found
12:02:08     INFO -   0:12.88 DEBUG: mkfshfs: Trying /builds/slave/rel-jamun_fx_m64_l10n_rpk-0000/build/jamun/hfsplus-tools/newfs_hfs
12:02:08     INFO -   0:12.88 ERROR: Cannot find mkfshfs
12:02:08     INFO -   0:12.92 *** Fix above errors and then restart with               "/usr/bin/make -f client.mk build"
12:02:08     INFO -   0:12.92 make: *** [configure] Error 1
12:02:08    ERROR - Return code: 2

Comment 1

[Rail Aliiev [:rail]]

I had to back out https://hg.mozilla.org/mozilla-central/rev/89ec4b65a5f6:
https://hg.mozilla.org/projects/jamun/rev/6eff992ce9629359406adb9335e089145ab2b09f

Comment 2

[Rail Aliiev [:rail]]

Looks like it helped (with reverted https://hg.mozilla.org/mozilla-central/rev/89ec4b65a5f6). Callek, do you think this may affect nightly l10n repacks (if we proceed with backout)?

Comment 3

[Justin Wood (:Callek)]

(In reply to Rail Aliiev [:rail] ⌚️ET from comment #2)
> Looks like it helped (with reverted
> https://hg.mozilla.org/mozilla-central/rev/89ec4b65a5f6). Callek, do you
> think this may affect nightly l10n repacks (if we proceed with backout)?

If we backout before beta it will break Nightly repacks.  There may be a way to make a patch that works on nightly and beta, but I'd want to defer that knowledge to a build peer, (like :mshal or :glandium)

Comment 4

[Rail Aliiev [:rail]]

we can probably add some "if `uname` == 'Linux'` there...

Comment 5

[Rail Aliiev [:rail]]

Mike, what you say wrt comment 2?

Comment 6

[Rail Aliiev [:rail]]

Testing https://hg.mozilla.org/projects/jamun/rev/54e8fa77f5e98be992c029213caf551cda0beb32 on jamun

Comment 7

[Mike Hommey [:glandium]]

Comment 6 looks like a good workaround.

Comment 8

[Rail Aliiev [:rail]]

It worked fine

Comment 9

[Rail Aliiev [:rail]]

Attachment: Bug 1380781 - Mac release promotion l10n repacks fail to download find mkfshfs

Review commit: https://reviewboard.mozilla.org/r/158074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158074/

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 8887277 [details]
Bug 1380781 - Mac release promotion l10n repacks fail to download find mkfshfs

https://reviewboard.mozilla.org/r/158074/#review163326

::: browser/config/mozconfigs/macosx64/l10n-mozconfig:4
(Diff revision 1)
>  . "$topsrcdir/browser/config/mozconfigs/common"
>  . "$topsrcdir/build/mozconfig.no-compile"
>  
> +if test `uname` = "Linux"; then

might be better to make that uname -s.

Comment 11

[Rail Aliiev [:rail]]

Comment on attachment 8887277 [details]
Bug 1380781 - Mac release promotion l10n repacks fail to download find mkfshfs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158074/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48c6a63f1ac8
Mac release promotion l10n repacks fail to download find mkfshfs r=glandium

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/48c6a63f1ac8