1375271 - mac cross compile l10n missing --target=x86_64-apple-darwin

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Aki Sasaki (not active)]

Working log from date-branch: https://public-artifacts.taskcluster.net/XbO6CJX2TsK1KoVb8pvw2w/0/public/logs/live_backing.log

mozilla-central is broken from downloading the dmg as a tar.bz2:

[task 2017-06-21T19:53:54.518564Z] 19:53:54     INFO -          wget --no-cache -nv --no-iri -N -O firefox-56.0a1.en-US.linux-x86_64.tar.bz2 'https://queue.taskcluster.net/v1/task/DHb_n5ZMRZOB-p4cXR33dQ/artifacts/public/build/target.dmg')

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1375271 - Add an explicit --target to osx l10n mozconfigs.

Before bug 1373150, the l10n mozconfigs would include
compilation-related mozconfigs, which include setting compiler paths,
and setting --target for cross builds. After bug 1373150, the
compilation-related mozconfigs are not included anymore, which made
--target unset for l10n builds, leaving it to configure to guess what it
is based on the host. Which for cross builds is Linux, so configure
would set things up for a linux build, which doesn't work to do osx
l10n repacks.

So we add back an explicit --target to those mozconfigs, without
including all the compilation-related things.

We set the target to x86_64-apple-darwin, which is the same as what was
set through build/macosx/cross-mozconfig.common. This is different from
what the native osx builds would get (x86_64-apple-darwin11.2.0), but
the extra version in that target is actually not relevant and native
builds shouldn't care that it's gone.

Review commit: https://reviewboard.mozilla.org/r/151530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151530/

Comment 2

[Chris AtLee [:catlee]]

Comment on attachment 8880152 [details]
Bug 1375271 - Add an explicit --target to osx l10n mozconfigs.

https://reviewboard.mozilla.org/r/151530/#review156466

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bc0e8df6e81
Add an explicit --target to osx l10n mozconfigs. r=catlee

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/e916ab827bab
Add an explicit --target to osx l10n mozconfigs. r=catlee,a=catlee DONTBUILD

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/89ec4b65a5f6
Add necessary DMG creation tools to the osx l10n mozconfigs. r=catlee,a=catlee DONTBUILD

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4bc0e8df6e81