Show the addon id in about:debugging

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Developer Tools: about:debugging
P5
normal
VERIFIED FIXED
a month ago
16 days ago

People

(Reporter: andym, Assigned: andym)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a month ago
We should show the add-on id in about:debugging. If the developer has specified it, then they will know what it is. But since we made applications > gecko > id optional we assign to the add-on in a couple of scenarios 1) during about:debugging as a temporary loading and 2) when signed by AMO.

Notably nativeMessaging needs this id.

So an add-on author might not know it, its simple to add so lets do that.
(Assignee)

Comment 1

a month ago
Created attachment 8886716 [details]
extension-id.PNG
(Assignee)

Updated

a month ago
Assignee: nobody → amckay
Priority: -- → P5
Comment hidden (mozreview-request)

Comment 3

a month ago
mozreview-review
Comment on attachment 8886782 [details]
bug 1380818 show the add-on id on about:debugging

https://reviewboard.mozilla.org/r/157574/#review162862

Looks great! 

Just a small unrelated thing I noticed: the addon title is smaller than the rest of the text. 
Maybe we should make it bold (same as in about:addons ?) to make it more noticeable?
Attachment #8886782 - Flags: review?(jdescottes) → review+
(Assignee)

Comment 4

a month ago
I've seen an image from mstriemer that changes a few things and I think it changes the text under the title. Not sure which bug that is though.
Flags: needinfo?(mstriemer)
Keywords: checkin-needed
The add-on title is indeed supposed to be bold. Looks like the other text should maybe be smaller as well.

I filed bug 1381550 to fix this.
Flags: needinfo?(mstriemer)

Comment 6

a month ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1dd2fccddf1f
show the add-on id on about:debugging r=jdescottes
Keywords: checkin-needed

Comment 7

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1dd2fccddf1f
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Comment 8

29 days ago
I have reproduced this Bug on Nightly 56.0a1 (2017-07-13) on Windows 10, 64 bit!

The bug's fix is now verified on latest  Nightly 56.0a1

Build ID    :	20170720030203
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170719]
I can see the feature implemented in Nightly 56.0a1 on Linux Mint(64 Bit)

Build ID 	20170720220700
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

[Bugday-20170719]

Updated

16 days ago
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
You need to log in before you can comment on or make changes to this bug.