Closed Bug 1380830 Opened 7 years ago Closed 6 years ago

Intermittent font-inflation/container-with-clamping.html == font-inflation/container-with-clamping-ref.html | image comparison, max difference: 255, number of differing pixels: 10142

Categories

(Core :: Layout: Text and Fonts, defect, P3)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: JanH)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell disabled])

Attachments

(1 file)

Bug 1380830 - Enable container-with-clamping reftest again. r?dbaron
46 bytes, text/x-phabricator-request
dbaron
: review+
Details | Review 
The first changeset on which this occurred is https://hg.mozilla.org/integration/autoland/rev/185b16ee154d039a2d22b387642d173ccb3dad00

The failure looks like what happens if we reflow with the wrong font inflation settings and then paint with the right ones.  I'm not sure what would cause that.
(In reply to David Baron :dbaron: ⌚️UTC-7 from comment #3)
> The first changeset on which this occurred is
> https://hg.mozilla.org/integration/autoland/rev/
> 185b16ee154d039a2d22b387642d173ccb3dad00

I think it started earlier, on inbound, https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=cec67bb0c3015b44137aff040bbe63c975462f74, bug 1378095.
Blocks: 1378095
Whiteboard: [stockwell needswork]
:dvander -- Might your changes for bug 1378095 have triggered this frequent intermittent test failure?
Flags: needinfo?(dvander)
No, that was a Windows-specific change to code that isn't hit in reftests.
Flags: needinfo?(dvander)
:jet - As triage owner, can you find someone to look at this very frequent intermittent?
Flags: needinfo?(bugs)
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d499efc1cb2c
Disable reftest container-with-clamping.html for frequent intermittent failures; r=me,test-only
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell disabled]
(In reply to Pulsebot from comment #17)
> Pushed by gbrown@mozilla.com:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/d499efc1cb2c
> Disable reftest container-with-clamping.html for frequent intermittent
> failures; r=me,test-only

The 'skip' needs to be on the front of the line.
Flags: needinfo?(bugs)
Why? 

The current annotation is effective. No trunk failures reported since July 26, and:

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-win64-pgo/mozilla-central_win8_64_test_pgo-reftest-bm119-tests1-windows-build62.txt.gz

INFO - REFTEST TEST-KNOWN-SKIP | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/font-inflation/container-with-clamping.html == file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/font-inflation/container-with-clamping-ref.html


Also, this ordering is consistent with many existing annotations like https://dxr.mozilla.org/mozilla-central/rev/36f95aeb4c77f7cf3b3366583008cd6e4b6b1dba/dom/canvas/test/reftest/reftest.list#134.
(In reply to Geoff Brown [:gbrown] from comment #22)
> Why? 

Was responding to comment 20. If these are from older trees, then all's well.
Priority: -- → P3
(In reply to David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 from comment #3)
> The first changeset on which this occurred is
> https://hg.mozilla.org/integration/autoland/rev/
> 185b16ee154d039a2d22b387642d173ccb3dad00
> 
> The failure looks like what happens if we reflow with the wrong font
> inflation settings and then paint with the right ones.  I'm not sure what
> would cause that.

Based on that description, what I've learned while investigating bug 1428670 and the fact that bug 1308876 was landed shortly before these failures started to happen, methinks that the latter bug is very probably to blame here.
Blocks: 1308876
No longer blocks: 1378095
Funnily enough I didn't yet manage to create a reftest for bug 1428670 that actually fails without that bug fixed, but conversely bug 1428670 does fix the intermittent failures for this reftest:
Without bug 1428670 fixed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a13455b75f4d11a582c299a6d14391e7e70c9ab6
With bug 1428670 fixed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a177256e8ee9456dd945643f1885b839db10bb2
Assignee: nobody → jh+bugzilla
Depends on: 1428670
Judging from the description in comment 3 and the fact that this test started
failing shortly after bug 1308876 landed, it is highly likely that this test is
being hit by the same issue as bug 1428670.
This also makes sense given that this test is supposed to test the clamping of
the effective container width for font inflation by the actually visible area of
that frame - be that the viewport for a top level document as in bug 1428670, or
the width of an <iframe> as in this test.

Without the patches for bug 1428670, this test is still failing very frequently.
With those patches applied on the other hand, no more failures are encountered.
Comment on attachment 9008172 [details]
Bug 1380830 - Enable container-with-clamping reftest again. r?dbaron

David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 has approved the revision.
Attachment #9008172 - Flags: review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/f38ac02fefac
Enable container-with-clamping reftest again. r=dbaron
Backed out 5 changesets (Bug 1428670, Bug 1380830) for perma failing tests/layout/generic/crashtests/742602.html

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f38ac02fefacf6c79e945a25db824b40267a2542

Backout link: https://hg.mozilla.org/integration/autoland/rev/5688a792346d144f2f7a2ac511d8f0d84dc217c6

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=202405719&repo=autoland&lineNumber=2357

[task 2018-09-29T19:59:56.662Z] 19:59:56     INFO -  REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/generic/crashtests/742602.html
[task 2018-09-29T19:59:56.662Z] 19:59:56     INFO -  REFTEST INFO | RESTORE PREFERENCE pref(font.size.inflation.emPerLine,0)
[task 2018-09-29T19:59:56.663Z] 19:59:56     INFO -  REFTEST INFO | SET PREFERENCE pref(font.size.inflation.emPerLine,15)
[task 2018-09-29T19:59:56.663Z] 19:59:56     INFO -  REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/generic/crashtests/742602.html | 244 / 361 (67%)
[task 2018-09-29T20:00:17.995Z] 20:00:17     INFO -  wait for org.mozilla.fennec_aurora complete; top activity=com.android.launcher
[task 2018-09-29T20:00:18.199Z] 20:00:18     INFO -  INFO | automation.py | Application ran for: 0:19:32.309316
[task 2018-09-29T20:00:18.200Z] 20:00:18     INFO -  INFO | zombiecheck | Reading PID log: /tmp/tmp3UxSgSpidlog
[task 2018-09-29T20:00:18.716Z] 20:00:18     INFO -  /data/tombstones does not exist; tombstone check skipped
[task 2018-09-29T20:00:19.535Z] 20:00:19     INFO -  REFTEST INFO | Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/tmpOq7yGT/5d9b16f8-58f7-0724-3bf8-323d1ad6aa4b.dmp /builds/worker/workspace/build/symbols
[task 2018-09-29T20:00:29.716Z] 20:00:29     INFO -  REFTEST INFO | Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/5d9b16f8-58f7-0724-3bf8-323d1ad6aa4b.dmp
[task 2018-09-29T20:00:29.716Z] 20:00:29     INFO -  REFTEST INFO | Saved app info as /builds/worker/workspace/build/blobber_upload_dir/5d9b16f8-58f7-0724-3bf8-323d1ad6aa4b.extra
[task 2018-09-29T20:00:29.720Z] 20:00:29     INFO -  REFTEST PROCESS-CRASH | http://10.0.2.2:8854/tests/layout/generic/crashtests/742602.html | application crashed [@ nsFontInflationData::FindFontInflationDataFor(nsIFrame const*)]
[task 2018-09-29T20:00:29.720Z] 20:00:29     INFO -  Crash dump filename: /tmp/tmpOq7yGT/5d9b16f8-58f7-0724-3bf8-323d1ad6aa4b.dmp
[task 2018-09-29T20:00:29.721Z] 20:00:29     INFO -  Operating system: Android
[task 2018-09-29T20:00:29.721Z] 20:00:29     INFO -                    0.0.0 Linux 2.6.29-gea477bb #1 Wed Sep 26 11:04:45 PDT 2012 armv7l
[task 2018-09-29T20:00:29.721Z] 20:00:29     INFO -  CPU: arm
[task 2018-09-29T20:00:29.722Z] 20:00:29     INFO -       ARMv7 ARM Cortex-A8 features: swp,half,thumb,fastmult,vfpv2,edsp,neon,vfpv3
[task 2018-09-29T20:00:29.722Z] 20:00:29     INFO -       1 CPU
[task 2018-09-29T20:00:29.722Z] 20:00:29     INFO -  GPU: UNKNOWN
[task 2018-09-29T20:00:29.722Z] 20:00:29     INFO -  Crash reason:  SIGSEGV
[task 2018-09-29T20:00:29.723Z] 20:00:29     INFO -  Crash address: 0x0
[task 2018-09-29T20:00:29.723Z] 20:00:29     INFO -  Process uptime: not available
[task 2018-09-29T20:00:29.723Z] 20:00:29     INFO -  Thread 12 (crashed)
[task 2018-09-29T20:00:29.724Z] 20:00:29     INFO -   0  libxul.so!nsFontInflationData::FindFontInflationDataFor(nsIFrame const*) [nsFontInflationData.cpp:f38ac02fefacf6c79e945a25db824b40267a2542 : 30 + 0x2]
[task 2018-09-29T20:00:29.724Z] 20:00:29     INFO -       r0 = 0x00000000    r1 = 0x9090c155    r2 = 0x60ad6a19    r3 = 0x0000001f
[task 2018-09-29T20:00:29.724Z] 20:00:29     INFO -       r4 = 0x0000001f    r5 = 0x6d9eb8b0    r6 = 0x6d9eb0e0    r7 = 0x52af9fd8
[task 2018-09-29T20:00:29.724Z] 20:00:29     INFO -       r8 = 0x00000012    r9 = 0x52afa468   r10 = 0x53df48a4   r12 = 0x00000003
[task 2018-09-29T20:00:29.725Z] 20:00:29     INFO -       fp = 0x00000000    sp = 0x52af9fd0    lr = 0x5e7eb42d    pc = 0x5e812d72
[task 2018-09-29T20:00:29.725Z] 20:00:29     INFO -      Found by: given as instruction pointer in context
[task 2018-09-29T20:00:29.725Z] 20:00:29     INFO -   1  libxul.so!nsLayoutUtils::InflationMinFontSizeFor(nsIFrame const*) [nsLayoutUtils.cpp:f38ac02fefacf6c79e945a25db824b40267a2542 : 8440 + 0x5]
[task 2018-09-29T20:00:29.726Z] 20:00:29     INFO -       r4 = 0x00000000    r5 = 0x6d9eb8b0    r6 = 0x6d9eb0e0    r7 = 0x52afa008
[task 2018-09-29T20:00:29.726Z] 20:00:29     INFO -       r8 = 0x00000012    r9 = 0x52afa468   r10 = 0x53df48a4    fp = 0x00000000
[task 2018-09-29T20:00:29.726Z] 20:00:29     INFO -       sp = 0x52af9fe0    lr = 0x5e7ad8f5    pc = 0x5e7ad8f5
[task 2018-09-29T20:00:29.727Z] 20:00:29     INFO -      Found by: call frame info
[task 2018-09-29T20:00:29.727Z] 20:00:29     INFO -   2  libxul.so!nsLayoutUtils::FontSizeInflationFor(nsIFrame const*) [nsLayoutUtils.cpp:f38ac02fefacf6c79e945a25db824b40267a2542 : 8475 + 0x5]
[task 2018-09-29T20:00:29.727Z] 20:00:29     INFO -       r4 = 0x6d9eb8b0    r5 = 0x6d9eb8b0    r6 = 0x0000bb80    r7 = 0x52afa020
[task 2018-09-29T20:00:29.727Z] 20:00:29     INFO -       r8 = 0x00000012    r9 = 0x52afa468   r10 = 0x53df48a4    fp = 0x00000000
[task 2018-09-29T20:00:29.728Z] 20:00:29     INFO -       sp = 0x52afa010    lr = 0x5e7ad82b    pc = 0x5e7ad82b
[task 2018-09-29T20:00:29.728Z] 20:00:29     INFO -      Found by: call frame info
[task 2018-09-29T20:00:29.729Z] 20:00:29     INFO -   3  libxul.so!mozilla::SizeComputationInput::ComputeMargin(mozilla::WritingMode, int) [ReflowInput.cpp:f38ac02fefacf6c79e945a25db824b40267a2542 : 131 + 0x5]
[task 2018-09-29T20:00:29.729Z] 20:00:29     INFO -       r2 = 0x00000014    r3 = 0x612c6328    r4 = 0x52afa468    r5 = 0x6d9eb8b0
[task 2018-09-29T20:00:29.729Z] 20:00:29     INFO -       r6 = 0x0000bb80    r7 = 0x52afa078    r8 = 0x00000012    r9 = 0x52afa468
[task 2018-09-29T20:00:29.729Z] 20:00:29     INFO -      r10 = 0x53df48a4    fp = 0x00000000    sp = 0x52afa028    lr = 0x5e7e674d
[task 2018-09-29T20:00:29.730Z] 20:00:29     INFO -       pc = 0x5e7e674d
[task 2018-09-29T20:00:29.730Z] 20:00:29     INFO -      Found by: call frame info
[task 2018-09-29T20:00:29.730Z] 20:00:29     INFO -   4  libxul.so!mozilla::SizeComputationInput::InitOffsets(mozilla::WritingMode, int, mozilla::LayoutFrameType, mozilla::SizeComputationInput::ReflowInputFlags, nsMargin const*, nsMargin const*, nsStyleDisplay const*) [ReflowInput.cpp:f38ac02fefacf6c79e945a25db824b40267a2542 : 2572 + 0x9]
[task 2018-09-29T20:00:29.731Z] 20:00:29     INFO -       r4 = 0x52afa468    r5 = 0x0000bb80    r6 = 0x00000000    r7 = 0x52afa108
[task 2018-09-29T20:00:29.731Z] 20:00:29     INFO -       r8 = 0x00000012    r9 = 0x52afa468   r10 = 0x53de9800    fp = 0x00000000
[task 2018-09-29T20:00:29.731Z] 20:00:29     INFO -       sp = 0x52afa080    lr = 0x5e7e2777    pc = 0x5e7e2777
[task 2018-09-29T20:00:29.731Z] 20:00:29     INFO -      Found by: call frame info
[task 2018-09-29T20:00:29.732Z] 20:00:29     INFO -   5  libxul.so!mozilla::ReflowInput::InitConstraints(nsPresContext*, mozilla::LogicalSize const&, nsMargin const*, nsMargin const*, mozilla::LayoutFrameType) [ReflowInput.cpp:f38ac02fefacf6c79e945a25db824b40267a2542 : 2280 + 0x1f]
[task 2018-09-29T20:00:29.732Z] 20:00:29     INFO -       r4 = 0x52afa238    r5 = 0x52afa520    r6 = 0x00000000    r7 = 0x52afa220
[task 2018-09-29T20:00:29.732Z] 20:00:29     INFO -       r8 = 0x00000001    r9 = 0x52afa468   r10 = 0x00000000    fp = 0x00000000
[task 2018-09-29T20:00:29.732Z] 20:00:29     INFO -       sp = 0x52afa110    lr = 0x5e7e385f    pc = 0x5e7e385f
[task 2018-09-29T20:00:29.733Z] 20:00:29     INFO -      Found by: call frame info
Flags: needinfo?(jh+bugzilla)
Flags: needinfo?(jh+bugzilla)
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/ec51b039eef1
Enable container-with-clamping reftest again. r=dbaron
Oops, forgot to remove the leave-open flag.
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Keywords: regression
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: