1381097 - Popups with APZ enabled to not repaint correctly after resize

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, P3)

Description

[Josh Tumath]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170714030205

Steps to reproduce:

1. Download the Feedly Notifier add-on (https://olsh.me/Feedly-Notifier/).
2. Click on the icon that the add-on puts in the navigation toolbar.


Actual results:

The panel appears for a few milliseconds starting to animate out from the button, but then it suddenly disappears.


Expected results:

The panel should have opened, showing either a Login button or a list of all of your Feedly reading list.

I have noticed this bug since the 2017-07-11 build of Nightly.

Comment 1

[Kris Maglione [:kmag]]

Apparently this is due to APZ being enabled for the popups, regardless of whether they have remote content.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1381097: Part 1 - Add default-false pref to enable APZ in remote popups.

Ideally, we definitely want APZ in remote popup browsers for the sake of
responsiveness. However, there are currently some serious painting and
checkerboarding issues that make APZ popups unsuitable for release
populations.

Once these issues are addressed, we should enable the preference by default.
But given the relative lack of testing, and the issues we've seen so far, we
should keep the preference so that we can disable it with a hotfix if further
issues arise.

Review commit: https://reviewboard.mozilla.org/r/157582/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157582/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8886804 [details]
Bug 1381097: Part 1 - Add default-false pref to enable APZ in remote popups.

https://reviewboard.mozilla.org/r/157582/#review162884

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/228602d59911f40a39c75841722be7c4b124c447
Bug 1381097: Part 1 - Add default-false pref to enable APZ in remote popups. r=kats

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/228602d59911

Comment 7

[Kevin Chen[:kechen] (UTC + 8)]

The problem is gone after this patch on my machine, Kris should we close this bug? or there are some reason that we should leave it opened?

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

When you get to this - let's decide if this can be closed or not.

Comment 9

[Kris Maglione [:kmag]]

The short term "fix" was to disable APZ in these popups. In the long term, we really want OOP popups to use APZ, so this will still need to be fixed in order to enable that.

Comment 11

[avada]

(In reply to Kris Maglione [:kmag] (long backlog; ping on IRC if you're blocked) from comment #9)
> The short term "fix" was to disable APZ in these popups. In the long term,
> we really want OOP popups to use APZ, so this will still need to be fixed in
> order to enable that.

Hmmm. For me having apz.allow_zooming enabled is what broke the webext button menus (bug 1416207). In contrast I have apz.popups.enabled enabled right now and the menus work.

Comment 12

[Kris Maglione [:kmag]]

That's not surprising. The problems are sporadic.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jbonisteel, maybe it's time to close this bug?

Comment 15

[Jessie [:jbonisteel] pls NI]

Looks like we can close it

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Fixed is a better resolution since we did fix it. Bug 1493208 is tracking re-enabling APZ for popups which is the remaining work here.