Closed
Bug 1381180
Opened 7 years ago
Closed 7 years ago
Refactor out StrokeOptions from DrawCommands
Categories
(Core :: Graphics, enhancement)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: mchang, Assigned: mchang)
References
Details
Attachments
(1 file)
7.44 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Since we have copies of mDashes everywhere and to copy them, create a new StrokeOptions commands which does this for us.
Attachment #8886722 -
Flags: review?(dvander)
Comment on attachment 8886722 [details] [diff] [review]
Add a StrokeOptionsCommand to store StrokeOptions data
Review of attachment 8886722 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/2d/DrawCommand.h
@@ +74,5 @@
> + // between now and replay.
> + if (aStrokeOptions.mDashLength) {
> + mDashes.resize(aStrokeOptions.mDashLength);
> + mStrokeOptions.mDashPattern = &mDashes.front();
> + PodCopy(&mDashes.front(), aStrokeOptions.mDashPattern, mStrokeOptions.mDashLength * sizeof(Float));
PodCopy does the sizeof(Float) for you.
Attachment #8886722 -
Flags: review?(dvander) → review+
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b25d6223cf67
Refactor out StrokeOptions from DrawCommands. r=dvander
Comment 3•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•