Closed Bug 1381180 Opened 7 years ago Closed 7 years ago

Refactor out StrokeOptions from DrawCommands

Categories

(Core :: Graphics, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: mchang, Assigned: mchang)

References

Details

Attachments

(1 file)

Since we have copies of mDashes everywhere and to copy them, create a new StrokeOptions commands which does this for us.
Attachment #8886722 - Flags: review?(dvander)
Comment on attachment 8886722 [details] [diff] [review]
Add a StrokeOptionsCommand to store StrokeOptions data

Review of attachment 8886722 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/DrawCommand.h
@@ +74,5 @@
> +    // between now and replay.
> +    if (aStrokeOptions.mDashLength) {
> +      mDashes.resize(aStrokeOptions.mDashLength);
> +      mStrokeOptions.mDashPattern = &mDashes.front();
> +      PodCopy(&mDashes.front(), aStrokeOptions.mDashPattern, mStrokeOptions.mDashLength * sizeof(Float));

PodCopy does the sizeof(Float) for you.
Attachment #8886722 - Flags: review?(dvander) → review+
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b25d6223cf67
Refactor out StrokeOptions from DrawCommands. r=dvander
https://hg.mozilla.org/mozilla-central/rev/b25d6223cf67
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: