1381180 - Refactor out StrokeOptions from DrawCommands

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Mason Chang [Inactive] [:mchang]]

Attachment: Add a StrokeOptionsCommand to store StrokeOptions data

Since we have copies of mDashes everywhere and to copy them, create a new StrokeOptions commands which does this for us.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8886722 [details] [diff] [review]
Add a StrokeOptionsCommand to store StrokeOptions data

Review of attachment 8886722 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/DrawCommand.h
@@ +74,5 @@
> +    // between now and replay.
> +    if (aStrokeOptions.mDashLength) {
> +      mDashes.resize(aStrokeOptions.mDashLength);
> +      mStrokeOptions.mDashPattern = &mDashes.front();
> +      PodCopy(&mDashes.front(), aStrokeOptions.mDashPattern, mStrokeOptions.mDashLength * sizeof(Float));

PodCopy does the sizeof(Float) for you.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b25d6223cf67
Refactor out StrokeOptions from DrawCommands. r=dvander

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b25d6223cf67