1381337 - Select dropdowns in popups should not be constrained to document viewport

Status: RESOLVED FIXED

(WebExtensions :: Frontend, enhancement)

Description

[Gary [:streetwolf52]]

Some drop down lists display above the clicked icon instead of below.  Some drop downs don't even appear. The ones I tested only have one item on the drop down, the other one is in the active box.  Also, popups that can be resized often whow up in a different location when the icon on the bottom right is dragged or doesn't do anything.

All things said the offending patch will cause grief for WE add-ons.

Comment 1

[Gary [:streetwolf52]]

I had to turn off WE OOP in order to continue using my WE add-ons.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1381337: Don't contstrain popup select dropdowns to the document viewport.

Review commit: https://reviewboard.mozilla.org/r/157614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157614/

Comment 3

[Gary [:streetwolf52]]

Attachment: Resize icon

A screenshot of the resize icon on an affected window.  WE add-on in this case is Textarea Cache Lite 2.2.8.

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8886883 [details]
Bug 1381337: Don't contstrain popup select dropdowns to the document viewport.

https://reviewboard.mozilla.org/r/157614/#review163020

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/42ad059f07ba5057d4dc1b0fe00d96a0ece73bde
Bug 1381337: Don't contstrain popup select dropdowns to the document viewport. r=aswan

Comment 6

[Gary [:streetwolf52]]

Just tried this patch on inbound.  So far all my WE add-ons are now working like before.  Kudos.

Comment 7

[Gary [:streetwolf52]]

There is still an issue with an add-on of mine when WE OOP is enabled.  The add-on Zoom Page WE 5.1. The option page for this add-on has a box where you define zoom levels.  It has a resize icon on the bottom right of the box.  Here's the results with screenshots:

http://imgur.com/EWIx8CN - Normal appearance.  No resizing has been done yet.

http://imgur.com/Wq5lxir - Zoom level box was resized.

http://imgur.com/UMKyd66 - Zoom level box resized with WE OOP disabled.

Comment 8

[Gary [:streetwolf52]]

The Options page is gotten via about:addons and clicking on the Extensions label on the left.  Then click on Options for Zoom Page WE.  Perhaps the location of the resizable box is a reason why it wasn't fixed.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/42ad059f07ba